Gave names to anonymous functions in the docs. Tried to be as semantic as possible. #17549

catcarbonell · 2020-10-02T04:12:37Z

Responding to issue #17200

ijjk · 2020-10-02T04:23:13Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	catcarbonell/next.js canary	Change
buildDuration	13s	13.6s	⚠️ +549ms
nodeModulesSize	63.1 MB	63.1 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	catcarbonell/next.js canary	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.493	2.514	⚠️ +0.02
/ avg req/sec	1002.7	994.24	⚠️ -8.46
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.473	1.507	⚠️ +0.03
/error-in-render avg req/sec	1696.75	1658.44	⚠️ -38.31

Client Bundles (main, webpack, commons)

	vercel/next.js canary	catcarbonell/next.js canary	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	catcarbonell/next.js canary	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	catcarbonell/next.js canary	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	catcarbonell/next.js canary	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	catcarbonell/next.js canary	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	catcarbonell/next.js canary	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	catcarbonell/next.js canary	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	catcarbonell/next.js canary	Change
buildDuration	15.3s	15.4s	⚠️ +76ms
nodeModulesSize	63.1 MB	63.1 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	catcarbonell/next.js canary	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	catcarbonell/next.js canary	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	catcarbonell/next.js canary	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	catcarbonell/next.js canary	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	catcarbonell/next.js canary	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	catcarbonell/next.js canary	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	catcarbonell/next.js canary	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.4 MB	5.4 MB	✓

Commit: a25a24a

lfades · 2020-10-02T15:33:23Z

docs/api-routes/dynamic-api-routes.md

@@ -16,7 +16,7 @@ API routes support [dynamic routes](/docs/routing/dynamic-routes.md), and follow
 For example, the API route `pages/api/post/[pid].js` has the following code:

 ```js
-export default (req, res) => {
+export default function PostId(req, res){


Let's either use handler for all the names, or something that focuses on what the function returns, e.g getPost (and doesn't start with an uppercase)

Sounds good. I'll go ahead and fix that. Thanks!

awareness481 · 2020-10-02T17:38:59Z

I'm confused, why is there a duplicate PR? There's an earlier PR that addresses the issue already.

catcarbonell · 2020-10-02T17:45:01Z

I'm confused, why is there a duplicate PR? There's an earlier PR that addresses the issue already.

I'm competitive. lol.

ijjk · 2020-10-02T22:18:42Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	catcarbonell/next.js canary	Change
buildDuration	10.8s	11.1s	⚠️ +332ms
nodeModulesSize	63.1 MB	63.1 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	catcarbonell/next.js canary	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.03	2.051	⚠️ +0.02
/ avg req/sec	1231.31	1218.76	⚠️ -12.55
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.167	1.151	-0.02
/error-in-render avg req/sec	2142.23	2172.63	+30.4

Client Bundles (main, webpack, commons)

	vercel/next.js canary	catcarbonell/next.js canary	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	catcarbonell/next.js canary	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	catcarbonell/next.js canary	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	catcarbonell/next.js canary	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	catcarbonell/next.js canary	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	catcarbonell/next.js canary	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	catcarbonell/next.js canary	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	catcarbonell/next.js canary	Change
buildDuration	12.5s	12.2s	-323ms
nodeModulesSize	63.1 MB	63.1 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	catcarbonell/next.js canary	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	catcarbonell/next.js canary	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	catcarbonell/next.js canary	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	catcarbonell/next.js canary	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	catcarbonell/next.js canary	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	catcarbonell/next.js canary	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	catcarbonell/next.js canary	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.4 MB	5.4 MB	✓

Commit: 1ea9ebe

lfades · 2020-10-05T20:55:04Z

Closing in favor of #17510

Gave names to anonymous functions. Tried to be as semantic as possible.

a25a24a

catcarbonell requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners October 2, 2020 04:12

ijjk added the type: documentation label Oct 2, 2020

lfades reviewed Oct 2, 2020

View reviewed changes

Merge branch 'canary' into canary

1ea9ebe

Jashnm mentioned this pull request Oct 5, 2020

change anonymous functions to named in docs examples #17510

Merged

lfades closed this Oct 5, 2020

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gave names to anonymous functions in the docs. Tried to be as semantic as possible. #17549

Gave names to anonymous functions in the docs. Tried to be as semantic as possible. #17549

catcarbonell commented Oct 2, 2020

ijjk commented Oct 2, 2020

lfades Oct 2, 2020

catcarbonell Oct 2, 2020

awareness481 commented Oct 2, 2020

catcarbonell commented Oct 2, 2020

ijjk commented Oct 2, 2020

lfades commented Oct 5, 2020

Gave names to anonymous functions in the docs. Tried to be as semantic as possible. #17549

Gave names to anonymous functions in the docs. Tried to be as semantic as possible. #17549

Conversation

catcarbonell commented Oct 2, 2020

ijjk commented Oct 2, 2020

Stats from current PR

lfades Oct 2, 2020

Choose a reason for hiding this comment

catcarbonell Oct 2, 2020

Choose a reason for hiding this comment

awareness481 commented Oct 2, 2020

catcarbonell commented Oct 2, 2020

ijjk commented Oct 2, 2020

Stats from current PR

lfades commented Oct 5, 2020