Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister old serviceworker code #1304

Merged
merged 1 commit into from Feb 27, 2017

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Feb 27, 2017

Bring back 1b9e877 with a check for the prefetch serviceworker + if serviceWorkers are supported by the browser

Fixes #1205

Bring back vercel@1b9e877 with a check for the prefetch serviceworker + if it is supported by the browser
@timneutkens
Copy link
Member Author

cc @arunoda @nkzawa @rauchg

@rauchg
Copy link
Member

rauchg commented Feb 27, 2017

Ok that's clever. I removed it because it was unregistering all serviceworkers before :D

@rauchg rauchg merged commit 01fa65d into vercel:master Feb 27, 2017
@timneutkens timneutkens deleted the remove-serviceworker branch February 27, 2017 19:16
@timneutkens
Copy link
Member Author

❤️

return
}

if (registration.active.scriptURL.indexOf('_next-prefetcher.js') === -1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+100

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants