Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support graceful shutdowns #36909

Merged
merged 8 commits into from May 16, 2022
Merged

Support graceful shutdowns #36909

merged 8 commits into from May 16, 2022

Conversation

sidwebworks
Copy link
Contributor

@sidwebworks sidwebworks commented May 14, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using 19693
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • [ x] Make sure the linting passes by running yarn lint

Closes #29959

packages/next/bin/next.ts Outdated Show resolved Hide resolved
packages/next/bin/next.ts Outdated Show resolved Hide resolved
@sidwebworks sidwebworks requested a review from ijjk May 15, 2022 15:57
@ijjk
Copy link
Member

ijjk commented May 15, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary sidwebworks/next.js canary Change
buildDuration 16s 16s ⚠️ +11ms
buildDurationCached 6.5s 6.7s ⚠️ +177ms
nodeModulesSize 478 MB 478 MB ⚠️ +364 B
Page Load Tests Overall increase ✓
vercel/next.js canary sidwebworks/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 3.907 3.875 -0.03
/ avg req/sec 639.86 645.16 +5.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.357 1.328 -0.03
/error-in-render avg req/sec 1842.05 1882.04 +39.99
Client Bundles (main, webpack)
vercel/next.js canary sidwebworks/next.js canary Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.4 kB 72.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary sidwebworks/next.js canary Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary sidwebworks/next.js canary Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.7 kB 2.7 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.71 kB 5.71 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary sidwebworks/next.js canary Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary sidwebworks/next.js canary Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary sidwebworks/next.js canary Change
buildDuration 18.2s 18.2s -75ms
buildDurationCached 6.6s 6.5s -88ms
nodeModulesSize 478 MB 478 MB ⚠️ +364 B
Page Load Tests Overall increase ✓
vercel/next.js canary sidwebworks/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 3.902 3.898 0
/ avg req/sec 640.78 641.34 +0.56
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.346 1.329 -0.02
/error-in-render avg req/sec 1857.54 1880.7 +23.16
Client Bundles (main, webpack)
vercel/next.js canary sidwebworks/next.js canary Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.5 kB 73.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary sidwebworks/next.js canary Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary sidwebworks/next.js canary Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.8 kB 5.8 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.77 kB 2.77 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary sidwebworks/next.js canary Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary sidwebworks/next.js canary Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: a4e48a1

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit 7b83c19 into vercel:canary May 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants