Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make esm default interpolation work with jest mock #36877

Merged
merged 3 commits into from May 13, 2022
Merged

Make esm default interpolation work with jest mock #36877

merged 3 commits into from May 13, 2022

Conversation

Brooooooklyn
Copy link
Contributor

fixes #36794

@ijjk
Copy link
Member

ijjk commented May 13, 2022 •
edited

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
buildDuration 16.3s 16.3s -2ms
buildDurationCached 6.4s 6.3s -50ms
nodeModulesSize 475 MB 475 MB ⚠️ +2.85 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.496 4.602 ⚠️ +0.11
/ avg req/sec 556.1 543.29 ⚠️ -12.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.726 1.724 0
/error-in-render avg req/sec 1448.68 1450.25 +1.57
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28.8 kB 28.8 kB ⚠️ +25 B
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.5 kB 72.5 kB ⚠️ +25 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 308 B 308 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.69 kB 2.7 kB ⚠️ +8 B
head-HASH.js gzip 359 B 359 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.7 kB 5.71 kB ⚠️ +11 B
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.64 kB 2.65 kB ⚠️ +4 B
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 391 B 391 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.9 kB 15.9 kB ⚠️ +23 B
Client Build Manifests Overall decrease ✓
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
_buildManifest.js gzip 459 B 458 B -1 B
Overall change 459 B 458 B -1 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
index.html gzip 531 B 532 B ⚠️ +1 B
link.html gzip 544 B 544 B ✓
withRouter.html gzip 526 B 527 B ⚠️ +1 B
Overall change 1.6 kB 1.6 kB ⚠️ +2 B

Diffs

Diff for _buildManifest.js 
@@ -8,12 +8,12 @@ self.__BUILD_MANIFEST = {
     "static\u002Fchunks\u002Fpages\u002Fcss-436fa6bb26fc4120.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-8e11b4c2953d70e9.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-a714d10b912e5a04.js"
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-544bb68363445a0e.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-c1372eeb4916d32c.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-550ed853173c68fb.js"],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-ca5e63d57db66cd2.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-6d25f8059d21ea6e.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-9ccd1df3f88508f7.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-113a7082ae16fbcb.js"
   ],
Diff for dynamic-HASH.js 
@@ -160,6 +160,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=dynamic.js.map
Diff for image-HASH.js 
@@ -1108,6 +1108,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=image.js.map
@@ -1319,6 +1322,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=use-intersection.js.map
Diff for link-HASH.js 
@@ -408,6 +408,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=link.js.map
@@ -619,6 +622,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=use-intersection.js.map
Diff for main-HASH.js 
@@ -244,6 +244,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=head-manager.js.map
@@ -1537,6 +1540,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=index.js.map
@@ -1566,6 +1572,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=next.js.map
@@ -1590,6 +1599,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=normalize-trailing-slash.js.map
@@ -1778,6 +1790,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=page-loader.js.map
@@ -1828,6 +1843,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=performance-relayer.js.map
@@ -1943,6 +1961,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=index.js.map
@@ -1985,6 +2006,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=request-idle-callback.js.map
@@ -2137,6 +2161,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=route-announcer.js.map
@@ -2541,6 +2568,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=route-loader.js.map
@@ -2864,6 +2894,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=router.js.map
@@ -3259,6 +3292,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=script.js.map
@@ -3284,6 +3320,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=refresh.js.map
@@ -3346,6 +3385,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=vitals.js.map
@@ -3399,6 +3441,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=trusted-types.js.map
@@ -3446,6 +3491,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=with-router.js.map
@@ -3777,6 +3825,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=amp.js.map
@@ -4082,6 +4133,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=head.js.map
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-205f82cacf5cda41.js"
+      src="/_next/static/chunks/main-48f45c4cae8866c7.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-205f82cacf5cda41.js"
+      src="/_next/static/chunks/main-48f45c4cae8866c7.js"
       defer=""
     ></script>
     <script
@@ -27,7 +27,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-ca5e63d57db66cd2.js"
+      src="/_next/static/chunks/pages/link-9ccd1df3f88508f7.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-205f82cacf5cda41.js"
+      src="/_next/static/chunks/main-48f45c4cae8866c7.js"
       defer=""
     ></script>
     <script
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
buildDuration 18.2s 18.8s ⚠️ +560ms
buildDurationCached 6.5s 6.4s -110ms
nodeModulesSize 475 MB 475 MB ⚠️ +2.85 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.532 4.607 ⚠️ +0.08
/ avg req/sec 551.65 542.62 ⚠️ -9.03
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.677 1.721 ⚠️ +0.04
/error-in-render avg req/sec 1490.91 1452.54 ⚠️ -38.37
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 29.2 kB 29.3 kB ⚠️ +60 B
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 73.1 kB 73.2 kB ⚠️ +60 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.71 kB 2.72 kB ⚠️ +8 B
head-HASH.js gzip 357 B 357 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.79 kB 5.8 kB ⚠️ +10 B
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.76 kB 2.77 kB ⚠️ +7 B
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.1 kB 16.1 kB ⚠️ +25 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
_buildManifest.js gzip 456 B 458 B ⚠️ +2 B
Overall change 456 B 458 B ⚠️ +2 B
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary vercel/next.js interpolate-getter-setter Change
index.html gzip 529 B 527 B -2 B
link.html gzip 544 B 542 B -2 B
withRouter.html gzip 527 B 524 B -3 B
Overall change 1.6 kB 1.59 kB -7 B

Diffs

Diff for _buildManifest.js 
@@ -8,12 +8,12 @@ self.__BUILD_MANIFEST = {
     "static\u002Fchunks\u002Fpages\u002Fcss-436fa6bb26fc4120.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-8e11b4c2953d70e9.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-a714d10b912e5a04.js"
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-544bb68363445a0e.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-c1372eeb4916d32c.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-550ed853173c68fb.js"],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-ca5e63d57db66cd2.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-6d25f8059d21ea6e.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-9ccd1df3f88508f7.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-113a7082ae16fbcb.js"
   ],
Diff for dynamic-HASH.js 
@@ -160,6 +160,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=dynamic.js.map
Diff for image-HASH.js 
@@ -1108,6 +1108,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=image.js.map
@@ -1319,6 +1322,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=use-intersection.js.map
Diff for link-HASH.js 
@@ -408,6 +408,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=link.js.map
@@ -619,6 +622,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=use-intersection.js.map
Diff for main-HASH.js 
@@ -244,6 +244,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=head-manager.js.map
@@ -1537,6 +1540,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=index.js.map
@@ -1566,6 +1572,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=next.js.map
@@ -1590,6 +1599,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=normalize-trailing-slash.js.map
@@ -1778,6 +1790,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=page-loader.js.map
@@ -1828,6 +1843,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=performance-relayer.js.map
@@ -1943,6 +1961,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=index.js.map
@@ -1985,6 +2006,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=request-idle-callback.js.map
@@ -2137,6 +2161,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=route-announcer.js.map
@@ -2541,6 +2568,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=route-loader.js.map
@@ -2864,6 +2894,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=router.js.map
@@ -3259,6 +3292,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=script.js.map
@@ -3284,6 +3320,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=refresh.js.map
@@ -3346,6 +3385,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=vitals.js.map
@@ -3399,6 +3441,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=trusted-types.js.map
@@ -3446,6 +3491,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=with-router.js.map
@@ -3777,6 +3825,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=amp.js.map
@@ -4082,6 +4133,9 @@
         typeof exports.default === "function" ||
         (typeof exports.default === "object" && exports.default !== null)
       ) {
+        Object.defineProperty(exports.default, "__esModule", {
+          value: true
+        });
         Object.assign(exports.default, exports);
         module.exports = exports.default;
       } //# sourceMappingURL=head.js.map
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-205f82cacf5cda41.js"
+      src="/_next/static/chunks/main-48f45c4cae8866c7.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-205f82cacf5cda41.js"
+      src="/_next/static/chunks/main-48f45c4cae8866c7.js"
       defer=""
     ></script>
     <script
@@ -27,7 +27,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-ca5e63d57db66cd2.js"
+      src="/_next/static/chunks/pages/link-9ccd1df3f88508f7.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-205f82cacf5cda41.js"
+      src="/_next/static/chunks/main-48f45c4cae8866c7.js"
       defer=""
     ></script>
     <script
Commit: 118ec01

@Brooooooklyn Brooooooklyn mentioned this pull request May 13, 2022
Closed
1 task
@kodiakhq kodiakhq bot merged commit 9e568da into canary May 13, 2022
@kodiakhq kodiakhq bot deleted the interpolate-getter-setter branch May 13, 2022 16:39
@ijjk ijjk mentioned this pull request May 18, 2022
Merged
3 tasks
kodiakhq bot pushed a commit that referenced this pull request May 18, 2022
@ijjk
Fix interopDefault on jest object-proxy (#37002)
f3c3113 
This fixes the interop default from #36877 on the jest `object-proxy` as it currently causes the below error when running tests in our `with-jest` example:

```sh
    TypeError: 'get' on proxy: property '__esModule' is a read-only and non-configurable data property on the proxy target but the proxy did not return its actual value (expected 'true' but got 'false')
```

## Bug

- [ ] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

x-ref: #36877
SukkaW pushed a commit to SukkaW/next.js that referenced this pull request May 18, 2022
@ijjk @SukkaW
Fix interopDefault on jest object-proxy (vercel#37002)
60dca6f 
This fixes the interop default from vercel#36877 on the jest `object-proxy` as it currently causes the below error when running tests in our `with-jest` example:

```sh
    TypeError: 'get' on proxy: property '__esModule' is a read-only and non-configurable data property on the proxy target but the proxy did not return its actual value (expected 'true' but got 'false')
```

## Bug

- [ ] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

x-ref: vercel#36877
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SukkaW SukkaW SukkaW left review comments

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

router client file is transpiled incorrectly
3 participants
@Brooooooklyn @ijjk @SukkaW