Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update moduleNameMapper jest config and remove extra deps #36787

Merged
merged 5 commits into from May 10, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 9, 2022

Noticed while testing #36784 against our with-jest example that the CSS mocks are failing since the @/pages mapping matches first and it seems we always want our mocks to come first to prevent this.

A previous issue had trouble with overriding .svg since it's grouped with our other image extensions so this breaks that out to it's own rule to make it easier to override.

Also noticed some extra dependencies being added which can be removed from the default with-jest example.

Documentation / Examples

  • Make sure the linting passes by running yarn lint

x-ref: #35634
Fixes: #36682

@ijjk ijjk added examples Issue/PR related to examples created-by: Next.js team PRs by the Next.js team type: next labels May 9, 2022
@ijjk
Copy link
Member Author

ijjk commented May 9, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/jest-config Change
buildDuration 16.2s 16.2s -38ms
buildDurationCached 6.3s 6.3s -88ms
nodeModulesSize 475 MB 475 MB ⚠️ +256 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/jest-config Change
/ failed reqs 0 0
/ total time (seconds) 3.973 3.987 ⚠️ +0.01
/ avg req/sec 629.27 627.05 ⚠️ -2.22
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.367 1.379 ⚠️ +0.01
/error-in-render avg req/sec 1829.44 1813.27 ⚠️ -16.17
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/jest-config Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/jest-config Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/jest-config Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.69 kB 2.69 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/jest-config Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/jest-config Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/jest-config Change
buildDuration 18.1s 18.3s ⚠️ +243ms
buildDurationCached 6.3s 6.2s -143ms
nodeModulesSize 475 MB 475 MB ⚠️ +256 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/jest-config Change
/ failed reqs 0 0
/ total time (seconds) 4.003 4.084 ⚠️ +0.08
/ avg req/sec 624.57 612.09 ⚠️ -12.48
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.44 1.402 -0.04
/error-in-render avg req/sec 1736.01 1782.87 +46.86
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/jest-config Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.1 kB 73.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/jest-config Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/jest-config Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/jest-config Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/jest-config Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: e57345f

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove ESLint, let's also remove this line:

"lint": "next lint",

@ijjk ijjk merged commit e05a95a into vercel:canary May 10, 2022
@ijjk ijjk deleted the update/jest-config branch May 10, 2022 21:36
kodiakhq bot pushed a commit that referenced this pull request May 12, 2022
Ref: #36842, #36632, #36787

Upgrading to Jest 28, and aligning Babel example with `with-jest`


## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team examples Issue/PR related to examples type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moduleNameMapper with next/jest no longer works well with absolute imports
2 participants