Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leftover todo in loader #36734

Merged
merged 1 commit into from May 6, 2022

Conversation

timneutkens
Copy link
Member

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented May 6, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
buildDuration 15.9s 16.1s ⚠️ +151ms
buildDurationCached 6.4s 6.2s -203ms
nodeModulesSize 475 MB 475 MB -268 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
/ failed reqs 0 0
/ total time (seconds) 3.763 3.744 -0.02
/ avg req/sec 664.36 667.8 +3.44
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.413 1.357 -0.06
/error-in-render avg req/sec 1769.89 1842.43 +72.54
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
buildDuration 17.7s 18s ⚠️ +266ms
buildDurationCached 6.2s 6.1s -132ms
nodeModulesSize 475 MB 475 MB -268 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
/ failed reqs 0 0
/ total time (seconds) 3.786 3.801 ⚠️ +0.02
/ avg req/sec 660.25 657.67 ⚠️ -2.58
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.363 1.373 ⚠️ +0.01
/error-in-render avg req/sec 1833.6 1821.29 ⚠️ -12.31
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.1 kB 73.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.5 kB 16.5 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/only-resolve-pages Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 5b0a818

@timneutkens timneutkens merged commit e78c42c into vercel:canary May 6, 2022
@timneutkens timneutkens deleted the fix/only-resolve-pages branch May 6, 2022 16:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants