Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fallbackable path module for node and edge runtime #36306

Merged
merged 7 commits into from Apr 21, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 20, 2022

x-ref: #36190
x-ref: #31506

  • Move nodejs ptah module usage to next-server, keep base-server and web-server headless for 'path'
  • Use a native module path for nodejs runtime and path polyfill for edge runtime

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 20, 2022
@huozhi huozhi mentioned this pull request Apr 20, 2022
15 tasks
@huozhi huozhi marked this pull request as ready for review April 20, 2022 11:50
@ijjk
Copy link
Member

ijjk commented Apr 20, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js base-server/remove-path Change
buildDuration 15.3s 15.2s -136ms
buildDurationCached 6s 5.9s -85ms
nodeModulesSize 485 MB 485 MB ⚠️ +1.18 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js base-server/remove-path Change
/ failed reqs 0 0
/ total time (seconds) 3.007 2.989 -0.02
/ avg req/sec 831.27 836.5 +5.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.143 1.175 ⚠️ +0.03
/error-in-render avg req/sec 2187.4 2127.63 ⚠️ -59.77
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js base-server/remove-path Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js base-server/remove-path Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js base-server/remove-path Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js base-server/remove-path Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js base-server/remove-path Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js base-server/remove-path Change
buildDuration 17.8s 18s ⚠️ +148ms
buildDurationCached 6s 6s ⚠️ +64ms
nodeModulesSize 485 MB 485 MB ⚠️ +1.18 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js base-server/remove-path Change
/ failed reqs 0 0
/ total time (seconds) 3.006 3.017 ⚠️ +0.01
/ avg req/sec 831.71 828.63 ⚠️ -3.08
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.149 1.173 ⚠️ +0.02
/error-in-render avg req/sec 2175.39 2131.55 ⚠️ -43.84
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js base-server/remove-path Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js base-server/remove-path Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js base-server/remove-path Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js base-server/remove-path Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js base-server/remove-path Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 31d676c

@huozhi huozhi marked this pull request as draft April 20, 2022 13:39
@huozhi huozhi changed the title Decouple nodejs path dependency from base server Use fallbackable path module for node and edge runtime Apr 20, 2022
@huozhi huozhi marked this pull request as ready for review April 20, 2022 15:15
@huozhi huozhi requested a review from shuding April 20, 2022 16:10
@kodiakhq kodiakhq bot merged commit 2bdf1bc into vercel:canary Apr 21, 2022
@huozhi huozhi deleted the base-server/remove-path branch April 21, 2022 09:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants