Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switchable server runtime #31506

Closed
12 of 15 tasks
shuding opened this issue Nov 16, 2021 · 3 comments · Fixed by #33395
Closed
12 of 15 tasks

Switchable server runtime #31506

shuding opened this issue Nov 16, 2021 · 3 comments · Fixed by #33395
Assignees
@shuding @huozhi
Labels
area: Server Components React Server Components
Projects
React Server Components in Next.js (A...

Comments

@shuding
Copy link
Member

shuding commented Nov 16, 2021 •
edited by huozhi

Currently, the SSR streaming (the Fizz architecture enabled with concurrentFeatures: true) server is always bundled as a middleware, targeting the web runtime. This behavior is confusing as well as lacking of flexibility. In order to make the runtime switchable between web and node, there are many necessary changes to be done in the near future:

Will probably split this into smaller tasks if needed.
@shuding shuding self-assigned this Nov 16, 2021
@shuding shuding added this to To do in React Server Components in Next.js (Alpha) via automation Nov 16, 2021
@shuding shuding moved this from To do to In Progress in React Server Components in Next.js (Alpha) Nov 16, 2021
@shuding shuding mentioned this issue Nov 16, 2021
Merged
10 tasks
kodiakhq bot pushed a commit that referenced this issue Nov 16, 2021
@shuding
Refactor the middleware SSR loader (#31508)
4ea7d7b 
Initial step for #31506, to move the adapter logic out of the loader output string so it will be easier to reuse code in the future. Also, more options are passed to the loader to align with the serverless loader.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
This was referenced Nov 25, 2021
Closed
Closed
@hamlim hamlim mentioned this issue Dec 2, 2021
Closed
@shuding shuding mentioned this issue Dec 2, 2021
Closed
10 tasks
This was referenced Dec 6, 2021
Merged
Open
@karaggeorge
Copy link
Contributor

Can't edit, but closed http PR in favor of #32999

@shuding shuding changed the title Switchable Fizz runtime Switchable server runtime Jan 12, 2022
@shuding shuding linked a pull request Jan 17, 2022 that will close this issue
Remove node fetch polyfill from base server #33395
Merged
@kodiakhq kodiakhq bot closed this as completed in #33395 Jan 17, 2022
React Server Components in Next.js (Alpha) automation moved this from In Progress to Done Jan 17, 2022
@shuding shuding reopened this Jan 17, 2022
React Server Components in Next.js (Alpha) automation moved this from Done to To do Jan 17, 2022
@shuding shuding moved this from To do to In Progress in React Server Components in Next.js (Alpha) Jan 17, 2022
@shuding shuding mentioned this issue Jan 19, 2022
Merged
10 tasks
kodiakhq bot pushed a commit that referenced this issue Jan 19, 2022
@shuding
Move middleware handling to node server (#33448)
4d3b2ea 
Part of #31506, this PR moves the code of middleware handling from the base server to the node server.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@huozhi huozhi mentioned this issue Jan 19, 2022
Merged
kodiakhq bot pushed a commit that referenced this issue Jan 19, 2022
@huozhi
Move static serving to next server (#33475)
8ca32f1 
Part of #31506

Decouple static serving logic from base-server, let them go to next-server only
@shuding shuding mentioned this issue Jan 20, 2022
Merged
10 tasks
kodiakhq bot pushed a commit that referenced this issue Jan 20, 2022
@shuding
Refactor base server to remove native dependencies (#33499)
1c1a4de 
Part of #31506, this PR removes `loadEnvConfig` and `chalk` from the base server while keeping the same behavior for the node server.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@shuding shuding mentioned this issue Feb 23, 2022
Merged
10 tasks
kodiakhq bot pushed a commit that referenced this issue Feb 24, 2022
@shuding
Add proper headers to responses in web server (#34723)
cc5345b 
This PR adds the `X-Powered-By` and `Content-Type` headers to responses sent by the web server. The latter enables compression for the Edge runtime. Still, the web server doesn't have `Content-Length` and `ETag` as the response is usually dynamic.

Part of #31506.

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@shuding shuding mentioned this issue Mar 3, 2022
Merged
10 tasks
kodiakhq bot pushed a commit that referenced this issue Mar 8, 2022
@shuding
Per-page runtime (#35011)
201f98e 
Partially implements #31317 and #31506. There're also some trade-offs made with this PR: since we can't know if a certain runtime will be used or not beforehand, we have to start both runtime compilers (Node.js and Edge) and then generate entrypoints correspondingly.

Note that with this PR, the global runtime is still required to use the per-page runtime.

## Bug

- [ ] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
This was referenced Mar 11, 2022
Merged
Merged
kodiakhq bot pushed a commit that referenced this issue Mar 11, 2022
@shuding
Ensure that pages manifest contains pages of both runtimes (#35243)
2b13c2f 
Previously we only run `PagesManifestPlugin` in the Node server runtime, because the Edge target doesn't need it as the web server and middleware SSR loader specially handled pages manifest. This cases entrypoints with the Edge runtime configured being missing from there and this PR fixes it.

Part of #31317 and #31506.

## Bug

- [ ] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
kodiakhq bot pushed a commit that referenced this issue Mar 11, 2022
@shuding
Remove the special _document-concurrent component (#35242)
3b9864d 
This PR removes the `` const documentPage = `_document${globalRuntime ? '-concurrent' : ''}` `` condition from the config resolution phrase, and only use the built-in one. And later when rendering, we can conditionally convert the default class component into a function component. This change is necessary for the switchable runtime feature (#31506).

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
shuding added a commit to shuding/next.js that referenced this issue Mar 11, 2022
@shuding
Remove the special _document-concurrent component (vercel#35242)
379bc50 
This PR removes the `` const documentPage = `_document${globalRuntime ? '-concurrent' : ''}` `` condition from the config resolution phrase, and only use the built-in one. And later when rendering, we can conditionally convert the default class component into a function component. This change is necessary for the switchable runtime feature (vercel#31506).

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

- [ ] Make sure the linting passes by running `yarn lint`
@huozhi huozhi mentioned this issue Mar 17, 2022
Merged
@shuding shuding mentioned this issue Mar 26, 2022
Merged
10 tasks
@huozhi huozhi mentioned this issue Mar 30, 2022
Closed
kodiakhq bot pushed a commit that referenced this issue Apr 1, 2022
@shuding
Initial implementation of statically optimized flight data of server …
0eb9f7e 
…component pages (#35619)

Part of #31506 and #34179. This PR ensures that in the `nodejs` runtime, the flight data is statically stored as a JSON file if possible. Most of the touched code is related to conditions of static/SSG/SSR when runtime and/or RSC is involved.

## Bug

- [ ] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@huozhi huozhi mentioned this issue Apr 1, 2022
Merged
6 tasks
kodiakhq bot pushed a commit that referenced this issue Apr 5, 2022
@huozhi
Custom app for switchable runtime (#35666)
67d25a5 
x-ref: #33149
RFCs:
- #30996
- #31506 

## Feature

- [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [x] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`
This was referenced Apr 18, 2022
Closed
Merged
@huozhi huozhi self-assigned this Apr 20, 2022
kodiakhq bot pushed a commit that referenced this issue Apr 21, 2022
@huozhi
Use fallbackable path module for node and edge runtime (#36306)
2bdf1bc 
x-ref: #36190
x-ref: #31506

* Move nodejs ptah module usage to next-server, keep base-server and web-server headless for `'path'`
* Use a native module `path` for nodejs runtime and `path` polyfill for edge runtime
nevilm-lt pushed a commit to nevilm-lt/next.js that referenced this issue Apr 22, 2022
@shuding @nevilm-lt
Move middleware handling to node server (vercel#33448)
ffa20c7 
Part of vercel#31506, this PR moves the code of middleware handling from the base server to the node server.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
nevilm-lt pushed a commit to nevilm-lt/next.js that referenced this issue Apr 22, 2022
@huozhi @nevilm-lt
Move static serving to next server (vercel#33475)
0323474 
Part of vercel#31506

Decouple static serving logic from base-server, let them go to next-server only
nevilm-lt pushed a commit to nevilm-lt/next.js that referenced this issue Apr 22, 2022
@shuding @nevilm-lt
Refactor base server to remove native dependencies (vercel#33499)
9324dfd 
Part of vercel#31506, this PR removes `loadEnvConfig` and `chalk` from the base server while keeping the same behavior for the node server.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@huozhi huozhi mentioned this issue Jun 15, 2022
Merged
kodiakhq bot pushed a commit that referenced this issue Jun 21, 2022
@huozhi
Migrate middleware ssr to edge functions (#37708)
2608e7d 
x-ref: #31506

This PR migrates existing SSR on edge from middleware to edge functions implmentation. So that we can get rid of limitation of middleware and resolve the conflicts between middleware and edge SSR routes.

* Adding edge functions matching route in middleware catch all route,keep the order as `middleware catch all` -> redirects/rewrites -> `edge catch all` -> others
* Dropping middleware related code for edge SSR: removing client info and preflight request handling
@huozhi
Copy link
Member

huozhi commented Jul 26, 2022

In preparation for stability, we are moving usage from pages/ to the new app/ folder as outlined in the Layouts RFC. Server Components will be the default for all routes inside app/. Server Components support is still unstable. Close this task as most of the work are done in 12.2.1. We'll be sharing more information soon on how you can test out early versions of app/.

@huozhi huozhi closed this as completed Jul 26, 2022
React Server Components in Next.js (Alpha) automation moved this from In Progress to Done Jul 26, 2022
@huozhi huozhi added the area: Server Components React Server Components label Jul 26, 2022
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuding shuding

@huozhi huozhi

Labels
area: Server Components React Server Components
Projects
No open projects
React Server Components in Next.js (A...
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove node fetch polyfill from base server huozhi/next.js
5 participants
@shuding @huozhi @timneutkens @karaggeorge @balazsorban44