Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for catch-all route params in NextRequest page type declaration #36137

Merged
merged 2 commits into from Apr 13, 2022
Merged

Add support for catch-all route params in NextRequest page type declaration #36137

merged 2 commits into from Apr 13, 2022

Conversation

prichey
Copy link
Contributor

@prichey prichey commented Apr 13, 2022

fixes #36136

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Apr 13, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
buildDuration 15s 15.1s ⚠️ +47ms
buildDurationCached 6s 5.9s -77ms
nodeModulesSize 484 MB 484 MB ⚠️ +33 B
Page Load Tests Overall increase ✓
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
/ failed reqs 0 0
/ total time (seconds) 3.008 2.991 -0.02
/ avg req/sec 831.24 835.81 +4.57
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.167 1.162 -0.01
/error-in-render avg req/sec 2142.91 2152.11 +9.2
Client Bundles (main, webpack)
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
buildDuration 17.9s 17.9s -80ms
buildDurationCached 6s 5.9s -52ms
nodeModulesSize 484 MB 484 MB ⚠️ +33 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
/ failed reqs 0 0
/ total time (seconds) 2.97 2.982 ⚠️ +0.01
/ avg req/sec 841.75 838.29 ⚠️ -3.46
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.152 1.224 ⚠️ +0.07
/error-in-render avg req/sec 2170.48 2042.53 ⚠️ -127.95
Client Bundles (main, webpack)
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.77 kB 5.77 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary prichey/next.js prichey/fix-nextrequest-page-params-type Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 1ce2cfe

@kodiakhq kodiakhq bot merged commit a5103d2 into vercel:canary Apr 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent type declaration for NextRequest.page.params for catch-all routes
2 participants