fix problem with HMR when middleware and page reference the same node_module #33873

sokra · 2022-02-01T16:06:16Z

fixes #31827

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

…_module

ijjk · 2022-02-01T21:24:00Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
buildDuration	12.7s	12.5s	-204ms
buildDurationCached	3.2s	3.2s	-39ms
nodeModulesSize	359 MB	359 MB	-661 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.956	3.018	⚠️ +0.06
/ avg req/sec	845.62	828.27	⚠️ -17.35
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.392	1.378	-0.01
/error-in-render avg req/sec	1796.1	1813.9	+17.8

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27.2 kB	27.2 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.1 kB	71.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall decrease ✓

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.94 kB	4.94 kB	-1 B
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.4 kB	14.3 kB	-1 B

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
index.html gzip	529 B	529 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Diffs

Diff for _buildManifest.js

@@ -12,7 +12,7 @@ self.__BUILD_MANIFEST = {
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-7100d3b2a548f0e4.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-538d621a0e670391.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-53463827ccaef972.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-f97943edf7ae3dd3.js"],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-f0a2c3bb0706d8b2.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-76232dd6bc335a24.js"

Diff for image-HASH.js

@@ -9,7 +9,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/image",
         function() {
-          return __webpack_require__(5924);
+          return __webpack_require__(3155);
         }
       ]);
       if (false) {
@@ -1087,7 +1087,7 @@
       /***/
     },
 
-    /***/ 5924: /***/ function(
+    /***/ 3155: /***/ function(
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__

Default Build with SWC (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
buildDuration	16.3s	16.1s	-177ms
buildDurationCached	3.2s	3.2s	⚠️ +20ms
nodeModulesSize	359 MB	359 MB	-661 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.942	2.967	⚠️ +0.02
/ avg req/sec	849.88	842.49	⚠️ -7.39
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.386	1.37	-0.02
/error-in-render avg req/sec	1803.46	1825.23	+21.77

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	27.4 kB	27.4 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.3 kB	71.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall decrease ✓

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.36 kB	2.36 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	911 B	911 B	✓
image-HASH.js gzip	4.98 kB	4.98 kB	-2 B
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.21 kB	2.21 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.3 kB	14.3 kB	-2 B

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bugfix/isolate-middleware-modules	Change
index.html gzip	530 B	530 B	✓
link.html gzip	543 B	543 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Diffs

Diff for _buildManifest.js

@@ -12,7 +12,7 @@ self.__BUILD_MANIFEST = {
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-7100d3b2a548f0e4.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-538d621a0e670391.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-53463827ccaef972.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-f97943edf7ae3dd3.js"],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-f0a2c3bb0706d8b2.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-76232dd6bc335a24.js"

Diff for image-HASH.js

@@ -9,7 +9,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/image",
         function() {
-          return __webpack_require__(5924);
+          return __webpack_require__(3155);
         }
       ]);
       if (false) {
@@ -1087,7 +1087,7 @@
       /***/
     },
 
-    /***/ 5924: /***/ function(
+    /***/ 3155: /***/ function(
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__

Commit: 93835c4

…_module (vercel#33873) fixes vercel#31827 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`

sokra requested review from huozhi, ijjk, padmaia, shuding and timneutkens as code owners February 1, 2022 16:06

ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 1, 2022

This comment has been minimized.

Sign in to view

fix problem with HMR when middleware and page reference the same node…

9afa1a8

…_module

sokra force-pushed the bugfix/isolate-middleware-modules branch from d72c9b9 to 9afa1a8 Compare February 1, 2022 16:35

This comment has been minimized.

Sign in to view

Merge branch 'canary' into bugfix/isolate-middleware-modules

93835c4

ijjk approved these changes Feb 1, 2022

View reviewed changes

kodiakhq bot merged commit a803638 into canary Feb 1, 2022

kodiakhq bot deleted the bugfix/isolate-middleware-modules branch February 1, 2022 21:46

github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix problem with HMR when middleware and page reference the same node_module #33873

fix problem with HMR when middleware and page reference the same node_module #33873

sokra commented Feb 1, 2022

This comment has been minimized.

This comment has been minimized.

ijjk commented Feb 1, 2022

Diffs

Diffs

fix problem with HMR when middleware and page reference the same node_module #33873

fix problem with HMR when middleware and page reference the same node_module #33873

Conversation

sokra commented Feb 1, 2022

Bug

Feature

Documentation / Examples

This comment has been minimized.

This comment has been minimized.

ijjk commented Feb 1, 2022

Stats from current PR

Diffs

Diffs