fix problem with HMR when middleware and page reference the same node…

…_module
vercel · Feb 1, 2022 · d72c9b9 · d72c9b9
1 parent 791c356
commit d72c9b9
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/packages/next/build/webpack-config.ts b/packages/next/build/webpack-config.ts
@@ -1256,13 +1256,6 @@ export default async function getBaseWebpackConfig(
             },
           ],
         },
-        {
-          ...nonUserCondition,
-          // Make all non-user modules to be compiled in a single layer
-          // This avoids compiling them mutliple times and avoids module id changes
-          issuerLayer: 'middleware',
-          layer: '',
-        },
         ...(!config.images.disableStaticImages
           ? [
               {

diff --git a/test/integration/middleware/hmr/node_modules/shared-package/index.js b/test/integration/middleware/hmr/node_modules/shared-package/index.js
diff --git a/test/integration/middleware/hmr/node_modules/shared-package/package.json b/test/integration/middleware/hmr/node_modules/shared-package/package.json
diff --git a/test/integration/middleware/hmr/pages/about/_middleware.js b/test/integration/middleware/hmr/pages/about/_middleware.js
@@ -1,5 +1,7 @@
 import { NextResponse } from 'next/server'
+import magicValue from 'shared-package'
 
 export function middleware(request) {
+  if (magicValue !== 42) throw new Error('shared-package problem')
   return NextResponse.rewrite(new URL('/about/a', request.url))
 }
diff --git a/test/integration/middleware/hmr/pages/index.js b/test/integration/middleware/hmr/pages/index.js
@@ -1,3 +1,6 @@
+import magicValue from 'shared-package'
+if (magicValue !== 42) throw new Error('shared-package problem')
+
 export default function Home() {
   return (
     <div>