Skip to content

Commit

Permalink
Keep react-dom/server.node in precompiled (#42138)
Browse files Browse the repository at this point in the history
In `server/render.tsx` we're switching between `react-dom/server.browser` and `react-dom/server` based on the react version users're using, unlike directly resolving them with nodejs on server side, turbopack needs to resolve both while bundling.
  • Loading branch information
huozhi committed Oct 29, 2022
1 parent 6028a7a commit ff0d082
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
17 changes: 17 additions & 0 deletions packages/next/compiled/react-dom/server.node.js
@@ -0,0 +1,17 @@
'use strict';

var l, s;
if (process.env.NODE_ENV === 'production') {
l = require('./cjs/react-dom-server-legacy.node.production.min.js');
s = require('./cjs/react-dom-server.node.production.min.js');
} else {
l = require('./cjs/react-dom-server-legacy.node.development.js');
s = require('./cjs/react-dom-server.node.development.js');
}

exports.version = l.version;
exports.renderToString = l.renderToString;
exports.renderToStaticMarkup = l.renderToStaticMarkup;
exports.renderToNodeStream = l.renderToNodeStream;
exports.renderToStaticNodeStream = l.renderToStaticNodeStream;
exports.renderToPipeableStream = s.renderToPipeableStream;
1 change: 0 additions & 1 deletion packages/next/taskfile.js
Expand Up @@ -1537,7 +1537,6 @@ export async function ncc_react(task, opts) {
await fs.remove(join(reactDomCompiledDir, 'static.browser.js'))
await fs.remove(join(reactDomCompiledDir, 'unstable_testing.js'))
await fs.remove(join(reactDomCompiledDir, 'test-utils.js'))
await fs.remove(join(reactDomCompiledDir, 'server.node.js'))
await fs.remove(join(reactDomCompiledDir, 'profiling.js'))
await fs.remove(
join(reactDomCompiledDir, 'unstable_server-external-runtime.js')
Expand Down

0 comments on commit ff0d082

Please sign in to comment.