Special case Set-Cookie

vercel · Oct 26, 2021 · d31615b · d31615b
1 parent 5a08c01
commit d31615b
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 2 deletions.
diff --git a/packages/next/server/next-server.ts b/packages/next/server/next-server.ts
@@ -1164,7 +1164,11 @@ export default class Server {
 
           for (const [key, value] of result.response.headers.entries()) {
             if (key !== 'content-encoding') {
-              res.setHeader(key, value)
+              if (key.toLowerCase() === 'set-cookie') {
+                res.setHeader(key, value.split(', '))
+              } else {
+                res.setHeader(key, value)
+              }
             }
           }
 

diff --git a/packages/next/server/web/utils.ts b/packages/next/server/web/utils.ts
@@ -38,6 +38,10 @@ export function toNodeHeaders(headers?: Headers): NodeHeaders {
   if (headers) {
     for (const [key, value] of headers.entries()) {
       result[key] = value
+      if (key.toLowerCase() === 'set-cookie') {
+        console.log('the value of the cookie header is' + value)
+        result[key] = value.split(', ')
+      }
     }
   }
   return result

diff --git a/test/integration/middleware-core/pages/responses/_middleware.js b/test/integration/middleware-core/pages/responses/_middleware.js
@@ -20,6 +20,11 @@ export async function middleware(request, ev) {
     next.headers.append('x-append-me', 'top')
   }
 
+  // Ensure deep can append to this value
+  if (url.searchParams.get('cookie-me') === 'true') {
+    next.headers.append('set-cookie', 'chocochip')
+  }
+
   // Sends a header
   if (url.pathname === '/responses/header') {
     next.headers.set('x-first-header', 'valid')

diff --git a/test/integration/middleware-core/pages/responses/deep/_middleware.js b/test/integration/middleware-core/pages/responses/deep/_middleware.js
@@ -6,5 +6,8 @@ export async function middleware(request, _event) {
   if (request.nextUrl.searchParams.get('append-me') === 'true') {
     next.headers.append('x-append-me', 'deep')
   }
+  if (request.nextUrl.searchParams.get('cookie-me') === 'true') {
+    next.headers.append('set-cookie', 'oatmeal')
+  }
   return next
 }
diff --git a/test/integration/middleware-core/test/index.test.js b/test/integration/middleware-core/test/index.test.js
@@ -329,11 +329,12 @@ function responseTests(locale = '') {
   it(`${locale} should respond with top level headers and override with deep headers`, async () => {
     const res = await fetchViaHTTP(
       context.appPort,
-      `${locale}/responses/deep?nested-header=true&append-me=true`
+      `${locale}/responses/deep?nested-header=true&append-me=true&cookie-me=true`
     )
     expect(res.headers.get('x-nested-header')).toBe('valid')
     expect(res.headers.get('x-deep-header')).toBe('valid')
     expect(res.headers.get('x-append-me')).toBe('top, deep')
+    expect(res.headers.raw()['set-cookie']).toEqual(['chocochip', 'oatmeal'])
   })
 }