Fix only generated case in minimal mode (#36130)

vercel · Apr 13, 2022 · d24eeb6 · d24eeb6
1 parent bc40c0b
commit d24eeb6
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/packages/next/server/base-server.ts b/packages/next/server/base-server.ts
@@ -1449,7 +1449,12 @@ export default abstract class Server {
 
         // skip manual revalidate if cache is not present and
         // revalidate-if-generated is set
-        if (isManualRevalidate && revalidateOnlyGenerated && !hadCache) {
+        if (
+          isManualRevalidate &&
+          revalidateOnlyGenerated &&
+          !hadCache &&
+          !this.minimalMode
+        ) {
           await this.render404(req, res)
           return null
         }

diff --git a/test/production/required-server-files.test.ts b/test/production/required-server-files.test.ts
@@ -235,6 +235,25 @@ describe('should set-up next', () => {
     expect(props2.gspCalls).not.toBe(props.gspCalls)
   })
 
+  it('should not 404 for onlyGenerated manual revalidate in minimal mode', async () => {
+    const previewProps = JSON.parse(
+      await next.readFile('standalone/.next/prerender-manifest.json')
+    ).preview
+
+    const res = await fetchViaHTTP(
+      appPort,
+      '/optional-ssg/only-generated-1',
+      undefined,
+      {
+        headers: {
+          'x-prerender-revalidate': previewProps.previewModeId,
+          'x-prerender-revalidate-if-generated': '1',
+        },
+      }
+    )
+    expect(res.status).toBe(200)
+  })
+
   it('should set correct SWR headers with notFound gsp', async () => {
     await waitFor(2000)
     await next.patchFile('standalone/data.txt', 'show')