Clean-up error when starting next with non-existent dir (#34830)

vercel · Feb 25, 2022 · d118d02 · d118d02
1 parent 1cf2cc8
commit d118d02
Show file tree

Hide file tree

Showing 2 changed files with 69 additions and 11 deletions.
diff --git a/packages/next/lib/get-project-dir.ts b/packages/next/lib/get-project-dir.ts
@@ -3,17 +3,29 @@ import path from 'path'
 import * as Log from '../build/output/log'
 
 export function getProjectDir(dir?: string) {
-  const resolvedDir = path.resolve(dir || '.')
-  const realDir = fs.realpathSync.native(resolvedDir)
+  try {
+    const resolvedDir = path.resolve(dir || '.')
+    const realDir = fs.realpathSync.native(resolvedDir)
 
-  if (
-    resolvedDir !== realDir &&
-    resolvedDir.toLowerCase() === realDir.toLowerCase()
-  ) {
-    Log.warn(
-      `Invalid casing detected for project dir, received ${resolvedDir} actual path ${realDir}, see more info here https://nextjs.org/docs/messages/invalid-project-dir-casing`
-    )
-  }
+    if (
+      resolvedDir !== realDir &&
+      resolvedDir.toLowerCase() === realDir.toLowerCase()
+    ) {
+      Log.warn(
+        `Invalid casing detected for project dir, received ${resolvedDir} actual path ${realDir}, see more info here https://nextjs.org/docs/messages/invalid-project-dir-casing`
+      )
+    }
 
-  return realDir
+    return realDir
+  } catch (err: any) {
+    if (err.code === 'ENOENT') {
+      Log.error(
+        `Invalid project directory provided, no such directory: ${path.resolve(
+          dir || '.'
+        )}`
+      )
+      process.exit(1)
+    }
+    throw err
+  }
 }
diff --git a/test/integration/cli/test/index.test.js b/test/integration/cli/test/index.test.js
@@ -48,7 +48,17 @@ describe('CLI Usage', () => {
         new RegExp(`Next\\.js v${pkg.version.replace(/\./g, '\\.')}`)
       )
     })
+
+    test('invalid directory', async () => {
+      const output = await runNextCommand(['non-existent'], {
+        stderr: true,
+      })
+      expect(output.stderr).toContain(
+        'Invalid project directory provided, no such directory'
+      )
+    })
   })
+
   describe('build', () => {
     test('--help', async () => {
       const help = await runNextCommand(['build', '--help'], {
@@ -109,6 +119,15 @@ describe('CLI Usage', () => {
       expect(code).toBe(expectedExitCode)
       expect(signal).toBe(expectedExitSignal)
     })
+
+    test('invalid directory', async () => {
+      const output = await runNextCommand(['build', 'non-existent'], {
+        stderr: true,
+      })
+      expect(output.stderr).toContain(
+        'Invalid project directory provided, no such directory'
+      )
+    })
   })
 
   describe('dev', () => {
@@ -253,6 +272,15 @@ describe('CLI Usage', () => {
       expect(code).toBe(expectedExitCode)
       expect(signal).toBe(expectedExitSignal)
     })
+
+    test('invalid directory', async () => {
+      const output = await runNextCommand(['dev', 'non-existent'], {
+        stderr: true,
+      })
+      expect(output.stderr).toContain(
+        'Invalid project directory provided, no such directory'
+      )
+    })
   })
 
   describe('start', () => {
@@ -337,6 +365,15 @@ describe('CLI Usage', () => {
       expect(code).toBe(expectedExitCode)
       expect(signal).toBe(expectedExitSignal)
     })
+
+    test('invalid directory', async () => {
+      const output = await runNextCommand(['start', 'non-existent'], {
+        stderr: true,
+      })
+      expect(output.stderr).toContain(
+        'Invalid project directory provided, no such directory'
+      )
+    })
   })
 
   describe('export', () => {
@@ -366,6 +403,15 @@ describe('CLI Usage', () => {
       })
       expect(stderr).not.toContain('UnhandledPromiseRejectionWarning')
     })
+
+    test('invalid directory', async () => {
+      const output = await runNextCommand(['export', 'non-existent'], {
+        stderr: true,
+      })
+      expect(output.stderr).toContain(
+        'Invalid project directory provided, no such directory'
+      )
+    })
   })
 
   describe('telemetry', () => {