chore: handles PR remarks

vercel · Dec 22, 2022 · c357a02 · c357a02
1 parent 2840c49
commit c357a02
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/packages/next/build/analysis/get-page-static-info.ts b/packages/next/build/analysis/get-page-static-info.ts
@@ -317,8 +317,9 @@ export async function getPageStaticInfo(params: {
         typeof resolvedRuntime !== 'string'
           ? `The \`runtime\` config must be a string. Please leave it empty or choose one of: ${options}`
           : `Provided runtime "${resolvedRuntime}" is not supported. Please leave it empty or choose one of: ${options}`
-      Log.error(message)
-      if (!isDev) {
+      if (isDev) {
+        Log.error(message)
+      } else {
         throw new Error(message)
       }
     }
@@ -342,8 +343,9 @@ export async function getPageStaticInfo(params: {
       !isAPIRoute(page.replace(/^\/pages\//, '/'))
     ) {
       const message = `Page ${page} provided runtime 'edge', the edge runtime for rendering is currently experimental. Use runtime 'experimental-edge' instead.`
-      Log.error(message)
-      if (!isDev) {
+      if (isDev) {
+        Log.error(message)
+      } else {
         throw new Error(message)
       }
     }

diff --git a/test/e2e/edge-configurable-runtime/index.test.ts b/test/e2e/edge-configurable-runtime/index.test.ts
@@ -122,7 +122,7 @@ describe('Configurable runtime for pages and API routes', () => {
         expect(output.code).toBe(1)
         expect(output.stderr).not.toContain(`Build failed`)
         expect(output.stderr).toContain(
-          `error - Page / provided runtime 'edge', the edge runtime for rendering is currently experimental. Use runtime 'experimental-edge' instead.`
+          `Error: Page / provided runtime 'edge', the edge runtime for rendering is currently experimental. Use runtime 'experimental-edge' instead.`
         )
       })
     })