Skip to content

Commit

Permalink
fix meaninglessFileNames type in compiler options schema (#39698)
Browse files Browse the repository at this point in the history
# Bug 

I would assume that this should be generated from TypeScript, but based on the [original PR](https://github.com/vercel/next.js/pull/38498/files) it wasn't clear that there was a way to generate these automatically.

Fixes the type of `styledComponents. topLevelImportPaths` and `styledComponents.meaninglessFileNames` so that it matches the [TypeScript type](https://github.com/vercel/next.js/blob/canary/packages/next/server/config-shared.ts#L457).

This was causing a warning here:

```
warn  - Invalid next.config.js options detected: 
  - The value at .compiler.styledComponents must be a boolean but it was an object.
  - The value at .compiler.styledComponents.meaninglessFileNames must be a boolean but it was an array.
  - The value at .compiler.styledComponents must match exactly one schema in oneOf.
 ```

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`



Co-authored-by: chaseadamsio <103162876+chaseadamsio@users.noreply.github.com>
  • Loading branch information
Chase Adams and chaseadamsio committed Aug 21, 2022
1 parent bc4d98a commit b7c2bd1
Showing 1 changed file with 20 additions and 6 deletions.
26 changes: 20 additions & 6 deletions packages/next/server/config-schema.ts
Expand Up @@ -111,11 +111,16 @@ const configSchema = {
type: 'boolean',
},
topLevelImportPaths: {
type: 'array',
items: {
type: 'string',
minLength: 1,
},
oneOf: [
{ type: 'boolean' },
{
type: 'array',
items: {
type: 'string',
minLength: 1,
},
},
],
},
ssr: {
type: 'boolean',
Expand All @@ -124,7 +129,16 @@ const configSchema = {
type: 'boolean',
},
meaninglessFileNames: {
type: 'boolean',
oneOf: [
{ type: 'boolean' },
{
type: 'array',
items: {
type: 'string',
minLength: 1,
},
},
],
},
minify: {
type: 'boolean',
Expand Down

0 comments on commit b7c2bd1

Please sign in to comment.