fix eslint link-passhref rule (#33857)

vercel · Feb 1, 2022 · a7793c7 · a7793c7
1 parent 3e60c23
commit a7793c7
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 4 deletions.
diff --git a/packages/eslint-plugin-next/lib/rules/link-passhref.js b/packages/eslint-plugin-next/lib/rules/link-passhref.js
@@ -23,7 +23,7 @@ module.exports = {
       },
 
       JSXOpeningElement(node) {
-        if (node.name.name !== 'Link' || node.name.name !== linkImport) {
+        if (node.name.name !== linkImport) {
           return
         }
 

diff --git a/test/unit/eslint-plugin-next/link-passhref.test.ts b/test/unit/eslint-plugin-next/link-passhref.test.ts
@@ -14,17 +14,23 @@ const ruleTester = new RuleTester()
 
 ruleTester.run('link-passhref', rule, {
   valid: [
-    `export const Home = () => (
+    `
+    import Link from 'next/link'
+    export const Home = () => (
       <Link href="/test"></Link>
     )`,
 
-    `export const Home = () => (
+    `
+    import Link from 'next/link'
+    export const Home = () => (
       <Link href="/test">
         <a>Test</a>
       </Link>
     )`,
 
-    `export const Home = () => (
+    `
+    import Link from 'next/link'
+    export const Home = () => (
       <Link href="/test" passHref>
         <StyledLink>Test</StyledLink>
       </Link>
@@ -37,6 +43,14 @@ ruleTester.run('link-passhref', rule, {
         <MyButton />
       </Link>
      )`,
+
+    `
+    import NextLink from 'next/link'
+    export const Home = () => (
+      <NextLink href="/test" passHref>
+        <StyledLink>Test</StyledLink>
+      </NextLink>
+    )`,
   ],
 
   invalid: [
@@ -57,6 +71,23 @@ ruleTester.run('link-passhref', rule, {
         },
       ],
     },
+    {
+      code: `
+      import NextLink from 'next/link'
+
+      export const Home = () => (
+        <NextLink href="/test">
+          <StyledLink>Test</StyledLink>
+        </NextLink>
+      )`,
+      errors: [
+        {
+          message:
+            'passHref is missing. See: https://nextjs.org/docs/messages/link-passhref',
+          type: 'JSXOpeningElement',
+        },
+      ],
+    },
     {
       code: `
       import Link from 'next/link'