Skip to content

Commit

Permalink
chore(eslint-config-next): bump eslint-import-resolver-typescript (#4…
Browse files Browse the repository at this point in the history
…3010)

<!--
Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change that you're making:
-->

## Bug

Bumps `eslint-import-resolver-typescript` in `eslint-config-next` to the
latest version to pick up a fix from `3.1.0`. As mentioned here,
import-js/eslint-import-resolver-typescript#107,
the typescript parser is unable to resolve the `typesVersions ` field in
their `package.json`. An example repo using this is
[`@vercel/examples-ui`](https://github.com/vercel/examples/blob/385a2e968619f9e50f488e2857e021841ae61030/packages/ui/package.json#L14-L22)
which will report an eslint `import/no-unresolved` error when using the
previous version of `eslint-import-resolver-typescript` (see
import-js/eslint-import-resolver-typescript#107).
This was fixed in
import-js/eslint-import-resolver-typescript#110

This can be locally fixed by bumping
`>=eslint-import-resolver-typescript@3.1.0` but decided it should be
resolved here too.

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [x] Errors have a helpful link attached, see `contributing.md`

Closes: #41786

Co-authored-by: JJ Kasper <jj@jjsweb.site>
  • Loading branch information
chanceaclark and ijjk committed Nov 16, 2022
1 parent 6bbb52e commit 7e195a2
Show file tree
Hide file tree
Showing 3 changed files with 69 additions and 29 deletions.
2 changes: 1 addition & 1 deletion packages/eslint-config-next/package.json
Expand Up @@ -13,7 +13,7 @@
"@rushstack/eslint-patch": "^1.1.3",
"@typescript-eslint/parser": "^5.42.0",
"eslint-import-resolver-node": "^0.3.6",
"eslint-import-resolver-typescript": "^2.7.1",
"eslint-import-resolver-typescript": "^3.5.2",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-jsx-a11y": "^6.5.1",
"eslint-plugin-react": "^7.31.7",
Expand Down
4 changes: 2 additions & 2 deletions packages/next/compiled/babel-packages/packages-bundle.js

Large diffs are not rendered by default.

92 changes: 66 additions & 26 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7e195a2

Please sign in to comment.