Optimize offline condition judgment (#33238)

* perf: optimize offline condition judgment * lint-fix Co-authored-by: JJ Kasper <jj@jjsweb.site>
vercel · Feb 2, 2022 · 6dfe02d · 6dfe02d
1 parent 04ca8db
commit 6dfe02d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 21 deletions.
diff --git a/packages/create-next-app/helpers/install.ts b/packages/create-next-app/helpers/install.ts
@@ -69,16 +69,13 @@ export function install(
        * install`.
        */
       args = ['install']
-      if (useYarn) {
-        if (!isOnline) {
-          console.log(chalk.yellow('You appear to be offline.'))
+      if (!isOnline) {
+        console.log(chalk.yellow('You appear to be offline.'))
+        if (useYarn) {
           console.log(chalk.yellow('Falling back to the local Yarn cache.'))
           console.log()
           args.push('--offline')
-        }
-      } else {
-        if (!isOnline) {
-          console.log(chalk.yellow('You appear to be offline.'))
+        } else {
           console.log()
         }
       }

diff --git a/packages/next-codemod/lib/install.ts b/packages/next-codemod/lib/install.ts
@@ -69,16 +69,13 @@ export function install(
        * install`.
        */
       args = ['install']
-      if (useYarn) {
-        if (!isOnline) {
-          console.log(chalk.yellow('You appear to be offline.'))
+      if (!isOnline) {
+        console.log(chalk.yellow('You appear to be offline.'))
+        if (useYarn) {
           console.log(chalk.yellow('Falling back to the local Yarn cache.'))
           console.log()
           args.push('--offline')
-        }
-      } else {
-        if (!isOnline) {
-          console.log(chalk.yellow('You appear to be offline.'))
+        } else {
           console.log()
         }
       }

diff --git a/packages/next/lib/helpers/install.ts b/packages/next/lib/helpers/install.ts
@@ -69,16 +69,13 @@ export function install(
        * install`.
        */
       args = ['install']
-      if (useYarn) {
-        if (!isOnline) {
-          console.log(chalk.yellow('You appear to be offline.'))
+      if (!isOnline) {
+        console.log(chalk.yellow('You appear to be offline.'))
+        if (useYarn) {
           console.log(chalk.yellow('Falling back to the local Yarn cache.'))
           console.log()
           args.push('--offline')
-        }
-      } else {
-        if (!isOnline) {
-          console.log(chalk.yellow('You appear to be offline.'))
+        } else {
           console.log()
         }
       }