Skip to content

Commit

Permalink
Skip creating VSCode config and .gitignore if running in CI (#43935)
Browse files Browse the repository at this point in the history
NEXT-233

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
  • Loading branch information
shuding committed Dec 11, 2022
1 parent 1fb4cad commit 6cfebfb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/next/lib/verifyTypeScriptSetup.ts
Expand Up @@ -125,7 +125,7 @@ export async function verifyTypeScriptSetup({
// Next.js' types:
await writeAppTypeDeclarations(dir, !disableStaticImages)

if (isAppDirEnabled) {
if (isAppDirEnabled && !isCI) {
await writeVscodeConfigurations(dir, tsPath)
}

Expand Down

0 comments on commit 6cfebfb

Please sign in to comment.