Skip to content

Commit

Permalink
fix: fixes #33314 move is-plain-object for es5 compilation (#33690)
Browse files Browse the repository at this point in the history
## Bug

- [ ] Related issues linked using `fixes #33314` #33314
- [ ] Moved the `is-plain-object` file to the shared directory since it's emitted to the client and thus needs to be transpiled.

This is just my 2nd PR so if I'm missing something please let me know.
  • Loading branch information
PizzaPete committed Jan 27, 2022
1 parent 33784f1 commit 662fa63
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/next/lib/is-error.ts
@@ -1,4 +1,4 @@
import { isPlainObject } from './is-plain-object'
import { isPlainObject } from '../shared/lib/is-plain-object'

// We allow some additional attached properties for Errors
export interface NextError extends Error {
Expand Down
5 changes: 4 additions & 1 deletion packages/next/lib/is-serializable-props.ts
@@ -1,4 +1,7 @@
import { isPlainObject, getObjectClassLabel } from './is-plain-object'
import {
isPlainObject,
getObjectClassLabel,
} from '../shared/lib/is-plain-object'

const regexpPlainIdentifier = /^[A-Za-z_$][A-Za-z0-9_$]*$/

Expand Down
File renamed without changes.

0 comments on commit 662fa63

Please sign in to comment.