Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Even though we never documented it, the `onLoad` prop used to work (in most cases) in Next.js 12.1.4 and broke in 12.1.5 once the code was refactored in PR #35889. We still shouldn't document it because `onLoad` doesn't work in all cases so [`onLoadingComplete`](https://nextjs.org/docs/api-reference/next/image#onloadingcomplete) is preferred, however tests were added for the cases that do work. Use cases that don't work with `onLoad` are Data URLs as well as `loading="eager"`.
- Loading branch information
Showing
3 changed files
with
179 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
test/integration/image-component/default/pages/on-load.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
import { useState } from 'react' | ||
import Image from 'next/image' | ||
|
||
const Page = () => { | ||
// Hoisted state to count each image load callback | ||
const [idToCount, setIdToCount] = useState({}) | ||
const [clicked, setClicked] = useState(false) | ||
|
||
return ( | ||
<div> | ||
<h1>Test onLoad</h1> | ||
<p> | ||
This is the native onLoad which doesn't work as many places as | ||
onLoadingComplete | ||
</p> | ||
<ImageWithMessage | ||
id="1" | ||
src="/test.jpg" | ||
layout="intrinsic" | ||
width="128" | ||
height="128" | ||
idToCount={idToCount} | ||
setIdToCount={setIdToCount} | ||
/> | ||
|
||
<ImageWithMessage | ||
id="2" | ||
src={require('../public/test.png')} | ||
placeholder="blur" | ||
layout="fixed" | ||
idToCount={idToCount} | ||
setIdToCount={setIdToCount} | ||
/> | ||
|
||
<ImageWithMessage | ||
id="3" | ||
src="/test.svg" | ||
layout="responsive" | ||
width="1200" | ||
height="1200" | ||
idToCount={idToCount} | ||
setIdToCount={setIdToCount} | ||
/> | ||
|
||
<ImageWithMessage | ||
id="4" | ||
src="/test.ico" | ||
layout="fill" | ||
objectFit="contain" | ||
idToCount={idToCount} | ||
setIdToCount={setIdToCount} | ||
/> | ||
|
||
<ImageWithMessage | ||
id="8" | ||
src={clicked ? '/foo/test-rect.jpg' : '/wide.png'} | ||
layout={clicked ? 'fixed' : 'intrinsic'} | ||
width="500" | ||
height="500" | ||
idToCount={idToCount} | ||
setIdToCount={setIdToCount} | ||
/> | ||
|
||
<button id="toggle" onClick={() => setClicked(!clicked)}> | ||
Toggle | ||
</button> | ||
<div id="footer" /> | ||
</div> | ||
) | ||
} | ||
|
||
function ImageWithMessage({ id, idToCount, setIdToCount, ...props }) { | ||
const [msg, setMsg] = useState('[LOADING]') | ||
const style = | ||
props.layout === 'fill' | ||
? { position: 'relative', width: '64px', height: '64px' } | ||
: {} | ||
return ( | ||
<> | ||
<div className="wrap" style={style}> | ||
<Image | ||
id={`img${id}`} | ||
onLoad={(e) => { | ||
let count = idToCount[id] || 0 | ||
count++ | ||
idToCount[id] = count | ||
setIdToCount(idToCount) | ||
const msg = `loaded ${count} ${e.target.id} with native onLoad` | ||
setMsg(msg) | ||
console.log(msg) | ||
}} | ||
{...props} | ||
/> | ||
</div> | ||
<p id={`msg${id}`}>{msg}</p> | ||
<hr /> | ||
</> | ||
) | ||
} | ||
|
||
export default Page |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters