Skip to content

Commit

Permalink
fix: bump node-sass peer dependency (#21084)
Browse files Browse the repository at this point in the history
Get rid of the unmet peer dependency warning when installing
a next.js project wtih node-sass 5.

node-sass 5 is the currently maintained version and removes
support one deprecated API and Node.js versions that Next.js does
not support either. Next.js uses node-sass 5 in devDependencies.

node-sass changelog: https://github.com/sass/node-sass/releases

On the other hand, as the docs encourage the sass package instead of node-sass,
(see errors/duplicate-sass.md)
I have updated examples which used node-sass 4 to the latest sass instead.
  • Loading branch information
ludofischer committed Jan 14, 2021
1 parent bddb022 commit 406c996
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion examples/with-carbon-components/package.json
Expand Up @@ -15,7 +15,7 @@
"carbon-components-react": "^7.3.0",
"carbon-icons": "^7.0.7",
"next": "latest",
"node-sass": "^4.12.0",
"sass": "^1.32.4",
"react": "^16.7.0",
"react-dom": "^16.7.0"
}
Expand Down
2 changes: 1 addition & 1 deletion examples/with-react-md-typescript/package.json
Expand Up @@ -17,7 +17,7 @@
"devDependencies": {
"@types/node": "^14.0.27",
"@types/react": "^16.9.43",
"node-sass": "^4.14.1",
"sass": "^1.32.4",
"typescript": "^3.9.7"
}
}
2 changes: 1 addition & 1 deletion examples/with-storybook-styled-jsx-scss/package.json
Expand Up @@ -11,7 +11,7 @@
},
"dependencies": {
"next": "^10.0.0",
"node-sass": "^4.14.1",
"sass": "^1.32.4",
"react": "17.0.1",
"react-dom": "17.0.1",
"styled-jsx-plugin-sass": "^1.0.0"
Expand Down
4 changes: 2 additions & 2 deletions examples/with-styled-jsx-scss/package.json
Expand Up @@ -8,10 +8,10 @@
},
"dependencies": {
"next": "latest",
"node-sass": "4.5.3",
"sass": "1.32.4",
"react": "^16.7.0",
"react-dom": "^16.7.0",
"styled-jsx-plugin-sass": "0.2.0"
"styled-jsx-plugin-sass": "1.0.0"
},
"license": "MIT"
}

0 comments on commit 406c996

Please sign in to comment.