Skip to content

Commit

Permalink
fix(#34030): ignore non-checkable jsx spread attribute (#34473)
Browse files Browse the repository at this point in the history
## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

Fixes #34030.

The PR is still WIP as the test case hasn't been added, help or change is welcome.

cc @no-ya @ijjk 

Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
  • Loading branch information
SukkaW and ijjk committed Feb 25, 2022
1 parent fe312ed commit 3ee458e
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 3 deletions.
20 changes: 17 additions & 3 deletions packages/eslint-plugin-next/lib/rules/inline-script-id.js
Expand Up @@ -28,16 +28,30 @@ module.exports = {
}

const attributeNames = new Set()

let hasNonCheckableSpreadAttribute = false
node.openingElement.attributes.forEach((attribute) => {
// Early return if we already have a non-checkable spread attribute, for better performance
if (hasNonCheckableSpreadAttribute) return

if (attribute.type === 'JSXAttribute') {
attributeNames.add(attribute.name.name)
} else if (attribute.type === 'JSXSpreadAttribute') {
attribute.argument.properties.forEach((property) => {
attributeNames.add(property.key.name)
})
if (attribute.argument && attribute.argument.properties) {
attribute.argument.properties.forEach((property) => {
attributeNames.add(property.key.name)
})
} else {
// JSXSpreadAttribute without properties is not checkable
hasNonCheckableSpreadAttribute = true
}
}
})

// https://github.com/vercel/next.js/issues/34030
// If there is a non-checkable spread attribute, we simply ignore them
if (hasNonCheckableSpreadAttribute) return

if (
node.children.length > 0 ||
attributeNames.has('dangerouslySetInnerHTML')
Expand Down
11 changes: 11 additions & 0 deletions test/unit/eslint-plugin-next/inline-script-id.test.ts
Expand Up @@ -98,6 +98,17 @@ ruleTester.run('inline-script-id', rule, {
)
}`,
},
{
code: `import Script from 'next/script';
const spread = { strategy: "lazyOnload" }
export default function TestPage() {
return (
<Script {...spread} id={"test-script"}>
{\`console.log('Hello world');\`}
</Script>
)
}`,
},
],
invalid: [
{
Expand Down

0 comments on commit 3ee458e

Please sign in to comment.