fix: allow resolving large JSON data in server components (#42025)

Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
vercel · Oct 30, 2022 · 2e6588d · 2e6588d
1 parent 6d53e8b
commit 2e6588d
Show file tree

Hide file tree

Showing 5 changed files with 2,170 additions and 18 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -10,7 +10,7 @@
       "request": "launch",
       "cwd": "${workspaceFolder}",
       "runtimeExecutable": "pnpm",
-      "runtimeArgs": ["debug-react-exp", "dev", "test/e2e/app-dir/app"],
+      "runtimeArgs": ["debug", "dev", "test/e2e/app-dir/app"],
       "skipFiles": ["<node_internals>/**"],
       "env": {
         "NEXT_PRIVATE_LOCAL_WEBPACK": "1"

diff --git a/packages/next/server/config.ts b/packages/next/server/config.ts
@@ -28,6 +28,11 @@ import { getDependencies } from '../lib/get-package-version'
 
 export { DomainLocale, NextConfig, normalizeConfig } from './config-shared'
 
+const NODE_16_VERSION = '16.8.0'
+const NODE_18_VERSION = '18.0.0'
+const isAboveNodejs16 = semverGte(process.version, NODE_16_VERSION)
+const isAboveNodejs18 = semverGte(process.version, NODE_18_VERSION)
+
 const experimentalWarning = execOnce(
   (configFileName: string, features: string[]) => {
     const s = features.length > 1 ? 's' : ''
@@ -52,21 +57,21 @@ const experimentalWarning = execOnce(
   }
 )
 
-export function setHttpClientAndAgentOptions(options: NextConfig) {
-  if (semverGte(process.version, '16.8.0')) {
-    if (
-      options.experimental?.enableUndici &&
-      semverGte(process.version, '18.0.0')
-    ) {
+export function setHttpClientAndAgentOptions(config: NextConfig) {
+  if (isAboveNodejs16) {
+    if (config.experimental?.enableUndici && isAboveNodejs18) {
       Log.warn(
-        '`enableUndici` option is unnecessary in Node.js v18.0.0 or greater.'
+        `\`enableUndici\` option is unnecessary in Node.js v${NODE_18_VERSION} or greater.`
       )
     } else {
-      ;(global as any).__NEXT_USE_UNDICI = options.experimental?.enableUndici
+      // When appDir is enabled undici is the default because of Response.clone() issues in node-fetch
+      ;(global as any).__NEXT_USE_UNDICI = config.experimental?.appDir
+        ? true
+        : config.experimental?.enableUndici
     }
-  } else if (options.experimental?.enableUndici) {
+  } else if (config.experimental?.enableUndici) {
     Log.warn(
-      '`enableUndici` option requires Node.js v16.8.0 or greater. Falling back to `node-fetch`'
+      `\`enableUndici\` option requires Node.js v${NODE_16_VERSION} or greater. Falling back to \`node-fetch\``
     )
   }
   if ((global as any).__NEXT_HTTP_AGENT) {
@@ -75,13 +80,13 @@ export function setHttpClientAndAgentOptions(options: NextConfig) {
     return
   }
 
-  if (!options) {
+  if (!config) {
     throw new Error('Expected config.httpAgentOptions to be an object')
   }
 
-  ;(global as any).__NEXT_HTTP_AGENT_OPTIONS = options.httpAgentOptions
-  ;(global as any).__NEXT_HTTP_AGENT = new HttpAgent(options.httpAgentOptions)
-  ;(global as any).__NEXT_HTTPS_AGENT = new HttpsAgent(options.httpAgentOptions)
+  ;(global as any).__NEXT_HTTP_AGENT_OPTIONS = config.httpAgentOptions
+  ;(global as any).__NEXT_HTTP_AGENT = new HttpAgent(config.httpAgentOptions)
+  ;(global as any).__NEXT_HTTPS_AGENT = new HttpsAgent(config.httpAgentOptions)
 }
 
 async function setFontLoaderDefaults(config: NextConfigComplete, dir: string) {
@@ -154,6 +159,16 @@ function assignDefaults(dir: string, userConfig: { [key: string]: any }) {
           for (const featureName of Object.keys(
             value
           ) as (keyof ExperimentalConfig)[]) {
+            const featureValue = value[featureName]
+            if (
+              featureName === 'appDir' &&
+              featureValue === true &&
+              !isAboveNodejs16
+            ) {
+              throw new Error(
+                `experimental.appDir requires Node v${NODE_16_VERSION} or later.`
+              )
+            }
             if (
               value[featureName] !== defaultConfig.experimental[featureName]
             ) {
@@ -608,8 +623,6 @@ function assignDefaults(dir: string, userConfig: { [key: string]: any }) {
     result.output = undefined
   }
 
-  // TODO: Change defaultConfig type to NextConfigComplete
-  // so we don't need "!" here.
   setHttpClientAndAgentOptions(result || defaultConfig)
 
   if (result.i18n) {