Fix server html insertion target (#42591)

Fixes #42493 Make sure searching for the close head tag instead of partial of head tag ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see `contributing.md`
vercel · Nov 7, 2022 · 01a1a7f · 01a1a7f
1 parent b1932b0
commit 01a1a7f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/packages/next/server/node-web-streams-helper.ts b/packages/next/server/node-web-streams-helper.ts
@@ -173,7 +173,7 @@ function createHeadInsertionTransformStream(
         freezing = true
       } else {
         const content = decodeText(chunk)
-        const index = content.indexOf('</head')
+        const index = content.indexOf('</head>')
         if (index !== -1) {
           const insertedHeadContent =
             content.slice(0, index) + insertion + content.slice(index)

diff --git a/test/.gitignore b/test/.gitignore
@@ -1 +1,2 @@
 !node_modules
+.vscode
diff --git a/test/e2e/app-dir/app-alias/next.config.js b/test/e2e/app-dir/app-alias/next.config.js
@@ -1,6 +1,5 @@
 module.exports = {
   experimental: {
     appDir: true,
-    transpileModules: ['ui'],
   },
 }
diff --git a/test/e2e/app-dir/app-alias/src/app/layout.tsx b/test/e2e/app-dir/app-alias/src/app/layout.tsx
@@ -1,8 +1,10 @@
 export default function Root({ children }: { children: React.ReactNode }) {
   return (
     <html>
-      <head></head>
-      <body>{children}</body>
+      <body>
+        <header>top bar</header>
+        {children}
+      </body>
     </html>
   )
 }