Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilerOptions from tsconfig.json #766

Merged
merged 8 commits into from Sep 9, 2021
Merged

Fix compilerOptions from tsconfig.json #766

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
81ba827
Fix module from tsconfig.json
styfle Sep 9, 2021
bb1e0e6
Pass all `compilerOptions`
styfle Sep 9, 2021
29bbcac
Add default `esnext`
styfle Sep 9, 2021
aaaa8e9
Add default module/target
styfle Sep 9, 2021
1b9077a
Fix bundle-subasset2 test
styfle Sep 9, 2021
bc9a557
Add ts-mixed-modules test
styfle Sep 9, 2021
d424517
Fix output-coverage
styfle Sep 9, 2021
6d5d6eb
Fix ts-mixed-modues output.js
styfle Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/index.js
View file
Open in desktop
Expand Up @@ -109,7 +109,7 @@ function ncc (
// add TsconfigPathsPlugin to support `paths` resolution in tsconfig
// we need to catch here because the plugin will
// error if there's no tsconfig in the working directory
let fullTsconfig;
let fullTsconfig = {};
try {
const tsconfig = tsconfigPaths.loadConfig();
fullTsconfig = loadTsconfig(tsconfig.configFileAbsolutePath) || {
Expand Down Expand Up @@ -334,15 +334,10 @@ function ncc (
transpileOnly,
compiler: eval('__dirname + "/typescript.js"'),
compilerOptions: {
...fullTsconfig.compilerOptions,
styfle marked this conversation as resolved.
Show resolved Hide resolved
allowSyntheticDefaultImports: true,
module: 'esnext',
outDir: '//',
...(fullTsconfig &&
fullTsconfig.compilerOptions &&
fullTsconfig.compilerOptions.incremental
? { incremental: false }
: {}),
styfle marked this conversation as resolved.
Show resolved Hide resolved
noEmit: false
noEmit: false,
outDir: '//'
}
}
}]
Expand Down