Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add console output when minifying fails #648

Merged
merged 4 commits into from
Mar 11, 2021
Merged

chore: add console output when minifying fails #648

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b857d27
chore: add console output when minifying fails
Songkeys Feb 1, 2021
6d97f89
chore(style): tabs to spaces
Songkeys Feb 1, 2021
382a7e5
Update error message
styfle Mar 11, 2021
66164bc
Merge branch 'master' into patch-1
kodiakhq[bot] Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,11 +410,14 @@ function ncc (
});
// For some reason, auth0 returns "undefined"!
// custom terser phase used over Webpack integration for this reason
if (result.code !== undefined)
if (result.code !== undefined) {
({ code, map } = {
code: result.code,
map: sourceMap ? JSON.parse(result.map) : undefined
});
} else {
console.log('Error happens when minifying. The result will not be minified.')
styfle marked this conversation as resolved.
Show resolved Hide resolved
}
}

if (v8cache) {
Expand Down