Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add Node.js 16 to CI #801

Merged
merged 8 commits into from Dec 22, 2021
Merged

chore: Add Node.js 16 to CI #801

merged 8 commits into from Dec 22, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 26, 2021

@styfle styfle requested a review from Timer as a code owner October 26, 2021 21:49
@styfle styfle changed the title Add Node.js 16 to CI chore: Add Node.js 16 to CI Dec 2, 2021
@styfle styfle mentioned this pull request Dec 3, 2021
Closed
@styfle
Copy link
Member Author

styfle commented Dec 22, 2021

I removed a couple dependencies that weren't working:

  • highlights which only has 500 downloads each week
  • pdf2json which has 50,000 downloads each week

We'll need to revisit if this is an actual bug in ncc

@styfle styfle merged commit 4edab22 into main Dec 22, 2021
@styfle styfle deleted the nodejs16 branch December 22, 2021 22:46
@chenrui333 chenrui333 mentioned this pull request Apr 4, 2022
Merged
@github-actions github-actions bot mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huozhi huozhi huozhi approved these changes

@Timer Timer Awaiting requested review from Timer Timer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@styfle @huozhi