runtime: upgrade nodejs runtime from v12 to v16 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
|
Should be a version bump after the PR merge. Thanks! |
mxschmitt
reviewed
Apr 4, 2022
| @@ -29,7 +29,7 @@ | |||
| "devDependencies": { | |||
| "@babel/core": "^7.15.0", | |||
| "@babel/preset-env": "^7.15.0", | |||
| "@vercel/ncc": "^0.29.0", | |||
| "@vercel/ncc": "^0.33.3", | |||
There was a problem hiding this comment.
whats the reasoning behind bumping ncc?
There was a problem hiding this comment.
no reasoning, but just thinking to use the latest.
There was a problem hiding this comment.
maybe this one in mind, vercel/ncc#801
mxschmitt
approved these changes
Apr 4, 2022
|
Thanks @mxschmitt ! |
iTrooz
pushed a commit
to iTrooz/action-tmate
that referenced
this pull request
Oct 9, 2022
Signed-off-by: Rui Chen <rui@chenrui.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 12 has an end of life on April 30, 2022.
This PR updates the default runtime to node16, rather then node12.
This is supported on all Actions Runners v2.285.0 or later.