Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilerOptions from tsconfig.json #766

Merged
merged 8 commits into from Sep 9, 2021
Merged

Fix compilerOptions from tsconfig.json #766

merged 8 commits into from Sep 9, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 9, 2021 •
edited

This will make sure we pass tsconfig.json to the loader.

In particular the module: commonjs option is important to ensure mixed module usage like tsc supports.

Fixes #765

@styfle styfle requested a review from Timer as a code owner September 9, 2021 17:19
styfle and others added 2 commits September 9, 2021 13:35
@styfle @guybedford
Add default esnext
29bbcac 
Co-authored-by: Guy Bedford <guybedford@gmail.com>
@styfle
Add default module/target
aaaa8e9
@styfle styfle changed the title Fix module from tsconfig.json Fix compilerOptions from tsconfig.json Sep 9, 2021
@styfle styfle merged commit be3bf78 into main Sep 9, 2021
@styfle styfle deleted the fix-ts-compiler-options-module branch September 9, 2021 20:27
@rethab rethab mentioned this pull request Nov 2, 2021
Open
@github-actions github-actions bot mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@Timer Timer Awaiting requested review from Timer Timer is a code owner

@sokra sokra Awaiting requested review from sokra

@mglagola mglagola Awaiting requested review from mglagola

@guybedford guybedford Awaiting requested review from guybedford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: ES Modules may not assign module.exports or exports.*, Use ESM export syntax
3 participants
@styfle @TooTallNate @guybedford