Support error in case of Infinity (#116)

* Support error in case of Infinity * remove isNaN
vercel · Feb 5, 2019 · d95e17f · d95e17f
1 parent 2669f23
commit d95e17f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -28,7 +28,7 @@ module.exports = function(val, options) {
   var type = typeof val;
   if (type === 'string' && val.length > 0) {
     return parse(val);
-  } else if (type === 'number' && isNaN(val) === false) {
+  } else if (type === 'number' && isFinite(val)) {
     return options.long ? fmtLong(val) : fmtShort(val);
   }
   throw new Error(

diff --git a/tests.js b/tests.js
@@ -283,4 +283,16 @@ describe('ms(invalid inputs)', function() {
       ms(NaN);
     }).to.throwError();
   });
+
+  it('should throw an error, when ms(Infinity)', function() {
+    expect(function() {
+      ms(Infinity);
+    }).to.throwError();
+  });
+
+  it('should throw an error, when ms(-Infinity)', function() {
+    expect(function() {
+      ms(-Infinity);
+    }).to.throwError();
+  });
 });