[edge-functions/jwt-authentication] Fix for breaking changes in Next.js canary #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuta
requested review from
okbel,
lfades,
goncy,
dominiksipowicz,
leerob and
steven-tey
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
BTW, this would be very confusing for people (even for me) to have two different APIs with the same method names (e.g. |
lfades
reviewed
Nov 2, 2022
lfades
approved these changes
Nov 2, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some following breaking changes were introduced in Next.js canary. This PR includes fixes for them.
NextCookiestoRequestCookiesandResponseCookiesnext.js#41526In addition to that, it also adds a runtime check to throw user-friendly error if
$JWT_SECRET_KEYis missing.Description
Demo URL
Type of Change
New Example Checklist
npm run new-examplewas used to create the example