export rsc util types #1536
Open
export rsc util types #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuding
requested changes
May 10, 2024
|
Added those exports in index file |
lgrammel
reviewed
May 14, 2024
| @@ -40,7 +40,7 @@ type RenderTool<PARAMETERS extends z.ZodTypeAny = any> = { | |||
| >; | |||
| }; | |||
|
|
|||
| type RenderText = Renderer< | |||
| export type RenderText = Renderer< | |||
There was a problem hiding this comment.
@shuding would renaming to TextRenderer make sense before exporting this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating reusable streaming ui tools, sometimes we have to seperate them in different files/modules that are not used directly within the
streamUIfunction but they loses their typings. It would be nice to explicitly add types to those functions.