Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if unprotected header contains crit param #81

Merged
merged 3 commits into from Jun 29, 2022

Conversation

qmuntal
Copy link
Contributor

@qmuntal qmuntal commented Jun 23, 2022

Fixes #80

Signed-off-by: qmuntal qmuntaldiaz@microsoft.com

Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've inlined a couple of suggestions.

headers.go Outdated Show resolved Hide resolved
headers.go Outdated Show resolved Hide resolved
headers.go Outdated Show resolved Hide resolved
qmuntal and others added 2 commits June 23, 2022 15:34
Co-authored-by: Thomas Fossati <tho.ietf@gmail.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qmuntal
Copy link
Contributor Author

qmuntal commented Jun 29, 2022

Can we have this merged?

@thomas-fossati thomas-fossati merged commit 62383c2 into veraison:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

“crit” label is permitted in unprotected headers
3 participants