Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload NCC Public Report #77

Merged
merged 1 commit into from Jun 13, 2022
Merged

Upload NCC Public Report #77

merged 1 commit into from Jun 13, 2022

Conversation

kevin-henry-ncc
Copy link
Contributor

@SteveLasker
Copy link
Contributor

@kevin-henry-ncc, can we get the DCO issue fixed?

Always ironic that PRs on a signing repo aren't signed :)

yogeshbdeshpande
yogeshbdeshpande approved these changes Jun 11, 2022
View reviewed changes
Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we agreed that NCC Auditors will create a PR for this ?

Anyway, if you have already discussed with them and then submitting, I am happy about it and hence approving the PR!

@yogeshbdeshpande
Copy link
Contributor

Ah, Thank you. I noticed that now! Look good to me!

@yogeshbdeshpande yogeshbdeshpande merged commit 07090f4 into veraison:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-fossati thomas-fossati thomas-fossati approved these changes

@yogeshbdeshpande yogeshbdeshpande yogeshbdeshpande approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevin-henry-ncc @SteveLasker @yogeshbdeshpande @thomas-fossati