Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use curve modulo instead of field size to calculate ECDSA signature length #60

Merged
merged 1 commit into from May 4, 2022
Merged

Use curve modulo instead of field size to calculate ECDSA signature length #60

merged 1 commit into from May 4, 2022

Conversation

qmuntal
Copy link
Contributor

@qmuntal qmuntal commented May 3, 2022 •
edited

@qmuntal
use curve modulo instead of field size to calculate ECDSA signature l…
7dd3375 
…ength

Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
@SteveLasker
Copy link
Contributor

SteveLasker commented May 3, 2022 •
edited

@sylvanc, @roywill can you also please provide some 👀's

thomas-fossati
thomas-fossati approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveLasker
Copy link
Contributor

Thanks @qmuntal, @jaredpar, @yogeshbdeshpande
@pornin, do you mind taking a look to confirm it meets your goals for #59?

@pornin
Copy link

pornin commented May 4, 2022

The change to ecdsa.go is exactly what I had in mind.

@SteveLasker
Copy link
Contributor

Thanks @pornin, awesome work @qmuntal

@SteveLasker SteveLasker merged commit b06d841 into veraison:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@thomas-fossati thomas-fossati thomas-fossati approved these changes

@yogeshbdeshpande yogeshbdeshpande yogeshbdeshpande approved these changes

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@henkbirkholz henkbirkholz Awaiting requested review from henkbirkholz henkbirkholz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field/order size confusion in ECDSA signature length
6 participants
@qmuntal @SteveLasker @pornin @jaredpar @thomas-fossati @yogeshbdeshpande