Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI and add first fuzz test #20

Merged
merged 4 commits into from Apr 1, 2022
Merged

Fix CI and add first fuzz test #20

merged 4 commits into from Apr 1, 2022

Conversation

qmuntal
Copy link
Contributor

@qmuntal qmuntal commented Mar 30, 2022 •
edited

This PR does several things:

  • Change CI scripts so they are executed on every PR and on every push to main. Previous behavior was to run them just on every push to main, and that's too late.
  • Remove circle-ci config file and related Makefile targets. We are using GH Actions instead of Circle CI. We probably inherited those files when the repo was forked.
  • Remove a fuzzing test which was not using the brand new built-in fuzzing framework.
  • Add a fuzz test which does something meaningful.

@qmuntal
Fix CI and run it on pull_request
f2a6e96 
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
@qmuntal
remove unecessary files and tests
08c0128 
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
@qmuntal
bump go directive to go1.18 to support built-in fuzzing
279ec76 
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
@qmuntal
add first fuzzing test
93cb3d3 
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
@qmuntal
Copy link
Contributor Author

qmuntal commented Mar 30, 2022

PTAL @thomas-fossati @SteveLasker @shizhMSFT

thomas-fossati
thomas-fossati approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good to me. Thanks!

SteveLasker
SteveLasker approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Merge, validate, learn, change, iterate, rinse repeat

@SteveLasker SteveLasker merged commit 2895992 into veraison:main Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveLasker SteveLasker SteveLasker approved these changes

@thomas-fossati thomas-fossati thomas-fossati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qmuntal @SteveLasker @thomas-fossati