Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example in the readme #114

Merged
merged 1 commit into from Nov 18, 2022
Merged

fix example in the readme #114

merged 1 commit into from Nov 18, 2022

Conversation

thomas-fossati
Copy link
Contributor

VerifyP256 creates a new verifier for ES512

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #114 (662a70b) into main (77e3f9f) will increase coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   91.79%   92.10%   +0.30%     
==========================================
  Files          10       10              
  Lines         975      975              
==========================================
+ Hits          895      898       +3     
+ Misses         54       51       -3     
  Partials       26       26              
Impacted Files Coverage Δ
cbor.go 84.21% <100.00%> (ø)
headers.go 93.05% <0.00%> (+0.90%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if DCO is fixed.

`VerifyP256` creates a new verifier for ES512

Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
@thomas-fossati thomas-fossati merged commit 4dbb9a7 into main Nov 18, 2022
@thomas-fossati thomas-fossati deleted the thomas-fossati-patch-1 branch November 18, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants