Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #769 : Mock files getting created in disk when dry-run is enabled #775

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

harshvar2
Copy link

@harshvar2 harshvar2 commented Apr 27, 2024

Description

Fix mock files and directory getting created in disk when dry-run mode is enabled.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.11
  • 1.12
  • 1.13
  • 1.14
  • 1.15
  • 1.16
  • 1.17
  • 1.18
  • 1.19
  • 1.20
  • 1.21
  • 1.22

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@harshvar2 harshvar2 changed the title Fxes #769 : mock file getting created in disk when dry-run is enabled Fixes #769 : mock file getting created in disk when dry-run is enabled Apr 27, 2024
…run mode is enabled

- dynamically set dry run config during Outputter initialization
@harshvar2 harshvar2 changed the title Fixes #769 : mock file getting created in disk when dry-run is enabled Fixes #769 : Mock files getting created in disk when dry-run is enabled Apr 27, 2024
@harshvar2
Copy link
Author

@LandonTClipp please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files being created even with dry-run: true
1 participant