【確認中】ブロックを読み込んでいるパスをsrcからbuildに変更 #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ブロックをロードするパスをsrcからbuildに変更 関連 #1034 WordPress/gutenberg#38715
shimotmk
changed the title
shimotmk
requested review from
mthaichi,
drill-lancer,
kurudrive and
sysbird
|
@shimotmk 拾えてない関数があるっぽいですー。 Fatal error: Uncaught Error: Call to undefined function vk_blocks_get_spacer_size_style_all() in /Users/kurudrive/Local Sites/x29/app/public/wp-content/plugins/vk-blocks-pro/inc/vk-blocks/vk-blocks-functions.php on line 179 これ @shimotmk さんの環境だと出ないです？ |
kurudrive
changed the title
|
@shimotmk あ... |
kurudrive
changed the title
kurudrive
approved these changes
Mar 1, 2022
|
@shimotmk あーりがとうございまーっす！ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ブロックを読み込んでいるパスをsrcからbuildに変更
関連 #1034
WordPress/gutenberg#38715
buildディレクトリにphpも出力されるようになったので変更しました
ビルドして問題なくブロックが編集できるか確認お願いします
この変更がリリースされたらsrc全体を配布ファイルから除外することが出来ます