Integrate DGraph fork changes #179
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync changes with upstream
Fixes GRAPHQL-789 This PR allows coercing of single values in variables to list.
fix(GraphQL): This PR change the coerced slice to type interface.
The following query was giving panic because here we passed ID as an int which is expected to be a string.
query allStories {
queryUser(filter: {
id: 22
}) {
stories {
id
text
}
}
}
We now added input coercion so that the ID type value will be coerced to string type. And if we give a slice of integer values or the required type is [ID] then that will be coerced to slice of integer values.
fix(GraphQL): Fix bug that got introduced in last commit , which doesn't allow string value in [ID] to be coerced to list.
Fixes GRAPHQL-1006 In this PR we have added input coercion for Integers which are passed in variables. Previously this code was part of dgraph.
Fixes: GRAPHQL-1007 We have allowed to paas @cascade arguments through variables in dgraph. For that we needed input validations check which is added in this library.
fix(GraphQL): fix validation when we give non-string value in variable and expected type is string.
fix(GraphQL): fix error while validation when we give Int or Float to String.
fix(GRAPHQL): Remove support of String --> int32 coercion in variables.
fix(Parser): Add directive argument validator
chore: adding order to the validation rules
fix(validate): fix race condition in rules sort
Signed-off-by: Steve Coffman <steve@khanacademy.org>
This was referenced Mar 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to integrate the DGraph fork changes, but I would prefer to do them individually, unfortunately both forks have diverged. Help wanted! Especially from the original authors like @pawanrawal @JatinDev543 @harshil-goel @anurags92 @NamanJain8