Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump d3-color from 2.0.0 to 3.0.1 #3241

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 8, 2021

Bumps d3-color from 2.0.0 to 3.0.1.

Release notes

Sourced from d3-color's releases.

v3.0.1

  • Make build reproducible.

v3.0.0

  • Adopt type: module.

This package now requires Node.js 12 or higher. For more, please read Sindre Sorhus’s FAQ.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [d3-color](https://github.com/d3/d3-color) from 2.0.0 to 3.0.1.
- [Release notes](https://github.com/d3/d3-color/releases)
- [Commits](d3/d3-color@v2.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: d3-color
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 8, 2021
@jheer jheer closed this Sep 20, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 20, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/d3-color-3.0.1 branch September 20, 2021 19:23
@jfmengels
Copy link

jfmengels commented Nov 3, 2021

Would it be possible to reconsider this change please? We have a security issue reported because of this dependency, and our security team is adamant about wanting it to be fixed.

EDIT: Sorry, I misread the security report for a long time. I thought the security issue in d3-color was solved in v3.0.1, and that this project was blocking the bump because of the dependency constraints, but I'm only realizing now that the issue is not solved over there at all. Very sorry for the disturbance 🙏

Thank you very much for your work on this amazing project ❤️

@jheer
Copy link
Member

jheer commented Nov 3, 2021

Thanks @jfmengels. Is this the same issue as #3321?

@jheer
Copy link
Member

jheer commented Nov 3, 2021

FWIW, I do plan to update d3-color as new releases are made. This automatic PR was closed in favor of a later manual update. Some of the new D3 modules have changed their settings to "type": "module" and we first need to make sure we don't have any downstream breakage when we switch to using those.

@jfmengels
Copy link

Yes it is the same issue. Thank you for considering this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants