fix(#9173): make mark.size support relative band size (e.g., {"band": 0.5}) for bars #9174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(by sharing the code for tick's dimension axis with rectangle/bar) Also convert `RectBinSpacingMixins` into `BandSizeConfigMixins`
…ze works with grouped bars) fix #9177
… 0.5}) for bars and ticks
kanitw
force-pushed
the
kw/9173-relative-band-size
branch
from
8c588b5
to
b2b2a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9173
Please review and merge #9176 first.
See the
bar_size_relative_band.svgexample pushed. It should be initially wrong, but then this PR makes it work.