Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: interactive aggregation threshold example #9123

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dwootton
Copy link
Contributor

@dwootton dwootton commented Oct 2, 2023

Added the interactive aggregation threshold example from this demo.

2023-10-02 09 20 42

@dwootton dwootton changed the title Added interactive aggregation threshold example [docs] Added interactive aggregation threshold example Oct 2, 2023
@dwootton dwootton changed the title [docs] Added interactive aggregation threshold example docs: Added interactive aggregation threshold example Oct 2, 2023
@dwootton
Copy link
Contributor Author

dwootton commented Oct 2, 2023

Addressing failed tests rn

@dwootton
Copy link
Contributor Author

dwootton commented Oct 2, 2023

Hmm no errors in editor, is there any known problems with the Node tests failing?
image

@domoritz domoritz changed the title docs: Added interactive aggregation threshold example docs: interactive aggregation threshold example Oct 3, 2023
@domoritz
Copy link
Member

domoritz commented Oct 3, 2023

Received: "must NOT have additional properties, must NOT have additional properties, must NOT have additional properties, must NOT have additional properties, must NOT have additional properties, must NOT have additional properties, must NOT have additional properties, must NOT have additional properties, must be array, must have required property 'data', must have required property 'data', must be object, must be string, must be number, must be boolean, must match exactly one schema in oneOf, must be object, must match exactly one schema in oneOf, must match exactly one schema in oneOf, must have required property 'signal', must match exactly one schema in oneOf, must be equal to one of the allowed values, must be equal to one of the allowed values, must be equal to one of the allowed values, must match exactly one schema in oneOf"

which is super hard to parse. Try making the spec in ts and validate against the Vega-Lite spec type:

export type TopLevelSpec =

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants