Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'yarn schema' command to CONTRIBUTING.md #8886

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

binste
Copy link

@binste binste commented May 6, 2023

No description provided.

@binste binste marked this pull request as draft May 6, 2023 15:20
@binste binste marked this pull request as ready for review May 6, 2023 15:29
@domoritz
Copy link
Member

domoritz commented May 6, 2023

Thanks for the pull request. I think we should rebuild the schema on build instead. What do you think?

@binste
Copy link
Author

binste commented May 7, 2023

Sounds good, I'd find that more convenient. To only compile VL without the schema one can still use build:only. I adjusted package.json (tested the command) and reverted the change in CONTRIBUTING.md.

yarn build is used in .github/workflows/test.yml and .release-it.json. I'm not familiar enough with the package to know if it's ok if the schema is now also rebuilt in those places.

@domoritz
Copy link
Member

domoritz commented May 7, 2023

Yeah, we need to comprehensively look through the scripts. I don't have time right now but will look at some point to resolve the issue you found.

@domoritz domoritz self-requested a review December 12, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants