fix: avoid repetitive labels for integer/year/yearmonth axes #8868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
force-pushed
the
kw/8967-repetitive-label
branch
2 times, most recently
from
eb9c73f
to
1fdae12
Compare
kanitw
force-pushed
the
kw/8967-repetitive-label
branch
from
ce7682d
to
28ebcb0
Compare
fandu-db
reviewed
Apr 27, 2023
| return minOfDefaultTickCountAndSpan(scaleName, defaultSignal, val => `year(${val})`); | ||
| } else if (unit === 'yearmonth') { | ||
| return minOfDefaultTickCountAndSpan(scaleName, defaultSignal, val => `(year(${val}) * 12 + month(${val}))`); | ||
| } |
There was a problem hiding this comment.
nit: Since we are doing this for month, why not also do it for quarter?
fandu-db
approved these changes
Apr 27, 2023
domoritz
requested changes
Apr 28, 2023
There was a problem hiding this comment.
This feels complicated. We should instead use tickMinStep as suggested in vega/vega#1503. Ideally this was fixed at the Vega level.
I'll look a bit but if it's too complicated, I don't think we should block this PR on that. |
It does -- see all the SVG changes in the 4th commit:
Note that some Vega spec may have diffs, but have no visual change since the cap rule still return the original default value. |
|
Replaced with #8872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8867
avoid repetitive labels for integer/year/yearmonth axes