Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repair docs site examples #8855

Conversation

hydrosquall
Copy link
Member

@hydrosquall hydrosquall commented Apr 21, 2023

Motivation

Changes

  • Ran yarn why vega-scale to find that both vega-scale 7.2.0 and 7.3.0 were present, when only was expecting
  • Pining repo to 7.3.0 would prevent different libraries from accessing different versions.

Testing

  • Build site locally, confirm that the currently broken examples render correctly
  • I'm not able to update the lockfile locally - something about python or C dependencies erroring out. Maybe this is something that can be regenerated and exported from CI, or by a maintainer with a working local environment.

Notes

  • Longer term fix -> try to adjust dependencies (possibly upstream) so that only one version of vega-scale is needed
  • TODO: look into visual regression testing to detect this type of issue programmatically in the future

@domoritz
Copy link
Member

Good find. Looks like the issue is that Vega depends on a specific version. I think we need to update Vega.

@domoritz
Copy link
Member

Superseded by #8857

@domoritz domoritz closed this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants