Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: typo error #8391

Merged
merged 1 commit into from Sep 26, 2022
Merged

docs: typo error #8391

merged 1 commit into from Sep 26, 2022

Conversation

danielmalaton
Copy link
Contributor

Please:

  • Make the pull requests (PRs) atomic (fix one issue at a time). Multiple relevant issues that must be fixed together? Make atomic commits so we can easily review each issue.
  • Provide a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties") so we can easily copy it to the release note.
    • Use imperative mood and present tense.
  • Mention relevant issues in the description (e.g., Fixes #1 / Fixes part of #1).
  • Lint and test (Run yarn test).
  • Review your changes before sending the PR (to ensure code quality).
  • For new features:
    • Add new unit tests.
    • Update the documentation under site/docs/ + add examples.

Tips:

@kanitw kanitw changed the title fix: typo error docs: typo error Aug 31, 2022
@domoritz domoritz merged commit 28257f3 into vega:next Sep 26, 2022
@vega-org-bot vega-org-bot mentioned this pull request Oct 1, 2022
Merged
@vega-org-bot vega-org-bot mentioned this pull request Oct 10, 2022
Merged
6 tasks
@vega-org-bot
Copy link
Collaborator

🚀 PR was released in v5.6.0 🚀

@vega-org-bot vega-org-bot added released This PR has been released by auto shipit and removed prerelease labels Oct 14, 2022
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
@danielmalaton @BradyJ27
docs: typo error (vega#8391)
1880236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released This PR has been released by auto shipit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielmalaton @vega-org-bot @domoritz